From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Richard Zhao <richard.zhao@linaro.org>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
eric.miao@linaro.org, patches@linaro.org,
devicetree-discuss@lists.ozlabs.org, alsa-devel@alsa-project.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 6/9] ARM: mx31ads: add audmux device
Date: Thu, 2 Feb 2012 14:16:36 +0000 [thread overview]
Message-ID: <20120202141636.GB22048@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120202141124.GG9773@S2101-09.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]
On Thu, Feb 02, 2012 at 10:11:26PM +0800, Shawn Guo wrote:
> On Thu, Feb 02, 2012 at 01:26:18PM +0000, Mark Brown wrote:
> > That's why I'm saying perhaps make it conditional on having ASoC built
> > (or even on having the AUDMUX driver built).
> Do you mean by having the below in some place like function
> imx31_soc_init()?
> #ifdef CONFIG_SND_MXC_SOC_AUDMUXV2
> imx_add_platform_device("audmux-v2", 0,
> audmux_res, ARRAY_SIZE(audmux_res), NULL, 0);
> #endif
Yes (you need to check for module too, there's a macro for that the name
of which escapes me right now).
> I do not think it's nice and consistent to the way that imx
> sub-architecture adds platform device.
Well, the i.MX thus far has had relatively few of these always present
type devices - it makes sense to make things conditional for devices
with external signals but for things entirely within the SoC the above
is less work.
> Furthermore, when a DT based board boots here, the code is broken.
> Explicitly adding the device by individual board as needed can easily
> align with DT based boards. By default, the audmux node in <soc>.dtsi
> file has status = "disabled", and any board that needs audmux device
> only need to overwrite status property of audmux node as 'okay' in its
> <board>.dts. Then DT core will add the audmux device when the board
> boots.
That seems like more work than is needed for boards, same issue applies.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/9] ARM: mx31ads: add audmux device
Date: Thu, 2 Feb 2012 14:16:36 +0000 [thread overview]
Message-ID: <20120202141636.GB22048@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120202141124.GG9773@S2101-09.ap.freescale.net>
On Thu, Feb 02, 2012 at 10:11:26PM +0800, Shawn Guo wrote:
> On Thu, Feb 02, 2012 at 01:26:18PM +0000, Mark Brown wrote:
> > That's why I'm saying perhaps make it conditional on having ASoC built
> > (or even on having the AUDMUX driver built).
> Do you mean by having the below in some place like function
> imx31_soc_init()?
> #ifdef CONFIG_SND_MXC_SOC_AUDMUXV2
> imx_add_platform_device("audmux-v2", 0,
> audmux_res, ARRAY_SIZE(audmux_res), NULL, 0);
> #endif
Yes (you need to check for module too, there's a macro for that the name
of which escapes me right now).
> I do not think it's nice and consistent to the way that imx
> sub-architecture adds platform device.
Well, the i.MX thus far has had relatively few of these always present
type devices - it makes sense to make things conditional for devices
with external signals but for things entirely within the SoC the above
is less work.
> Furthermore, when a DT based board boots here, the code is broken.
> Explicitly adding the device by individual board as needed can easily
> align with DT based boards. By default, the audmux node in <soc>.dtsi
> file has status = "disabled", and any board that needs audmux device
> only need to overwrite status property of audmux node as 'okay' in its
> <board>.dts. Then DT core will add the audmux device when the board
> boots.
That seems like more work than is needed for boards, same issue applies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120202/21058621/attachment.sig>
next prev parent reply other threads:[~2012-02-02 14:16 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 2:11 [PATCH v2 0/9] imx patches when I enable imx6q sabrelite audio Richard Zhao
2012-02-02 2:11 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 1/9] ARM: mxc: make imx_dma_is_general_purpose more generic for sdma Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 2/9] ARM: imx6q: add cko1 clock Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 3/9] ARM: dts: imx6q-sabrelite: add 2p5v and 3p3v regulators Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 4/9] ARM: dts: imx6q-sabrelite: add sgtl5000 audio codec Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 11:24 ` Fabio Estevam
2012-02-02 11:24 ` Fabio Estevam
2012-02-02 13:49 ` Richard Zhao
2012-02-02 13:49 ` Richard Zhao
2012-02-02 14:15 ` Fabio Estevam
2012-02-02 14:15 ` Fabio Estevam
2012-02-02 14:41 ` Richard Zhao
2012-02-02 14:41 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 5/9] ARM: mxc: convert audmux-v2 to a platform driver Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 6/9] ARM: mx31ads: add audmux device Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 8:55 ` Shawn Guo
2012-02-02 8:55 ` Shawn Guo
2012-02-02 9:11 ` Shawn Guo
2012-02-02 9:11 ` Shawn Guo
2012-02-02 9:24 ` Richard Zhao
2012-02-02 9:24 ` Richard Zhao
2012-02-02 13:09 ` Shawn Guo
2012-02-02 13:09 ` Shawn Guo
2012-02-02 13:58 ` Richard Zhao
2012-02-02 13:58 ` Richard Zhao
2012-02-02 14:09 ` Mark Brown
2012-02-02 14:09 ` Mark Brown
2012-02-02 14:25 ` Shawn Guo
2012-02-02 14:25 ` Shawn Guo
2012-02-03 2:15 ` Richard Zhao
2012-02-03 2:15 ` Richard Zhao
2012-02-03 13:32 ` Shawn Guo
2012-02-03 13:32 ` Shawn Guo
2012-02-05 4:50 ` Richard Zhao
2012-02-05 4:50 ` Richard Zhao
2012-02-14 1:35 ` Richard Zhao
2012-02-14 1:35 ` Richard Zhao
2012-02-14 6:06 ` Mark Brown
2012-02-14 6:06 ` Mark Brown
2012-02-14 7:34 ` Richard Zhao
2012-02-14 7:34 ` Richard Zhao
2012-02-14 17:23 ` Mark Brown
2012-02-14 17:23 ` Mark Brown
2012-02-03 13:27 ` Shawn Guo
2012-02-03 13:27 ` Shawn Guo
2012-02-02 12:09 ` Mark Brown
2012-02-02 12:09 ` Mark Brown
2012-02-02 13:17 ` Shawn Guo
2012-02-02 13:17 ` Shawn Guo
2012-02-02 13:26 ` Mark Brown
2012-02-02 13:26 ` Mark Brown
2012-02-02 14:11 ` Shawn Guo
2012-02-02 14:11 ` Shawn Guo
2012-02-02 14:16 ` Mark Brown [this message]
2012-02-02 14:16 ` Mark Brown
2012-02-02 2:12 ` [PATCH v2 7/9] ARM: mxc: move audmux-v2 to sound/soc/imx Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 9:02 ` Shawn Guo
2012-02-02 9:02 ` Shawn Guo
2012-02-02 9:42 ` Richard Zhao
2012-02-02 9:42 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 8/9] ASoC: imx: add dt support for audmux-v2 Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 12:10 ` Mark Brown
2012-02-02 12:10 ` Mark Brown
2012-02-02 14:02 ` Richard Zhao
2012-02-02 14:02 ` Richard Zhao
2012-02-02 2:12 ` [PATCH v2 9/9] ARM: imx6q-sabrelite: add audmux support Richard Zhao
2012-02-02 2:12 ` Richard Zhao
2012-02-02 8:30 ` Shawn Guo
2012-02-02 8:30 ` Shawn Guo
2012-02-02 8:22 ` Richard Zhao
2012-02-02 8:22 ` Richard Zhao
2012-02-02 8:32 ` Shawn Guo
2012-02-02 8:32 ` Shawn Guo
2012-02-27 7:59 ` [PATCH v2 0/9] imx patches when I enable imx6q sabrelite audio Shawn Guo
2012-02-27 7:59 ` Shawn Guo
2012-02-28 12:07 ` Richard Zhao
2012-02-28 12:07 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202141636.GB22048@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eric.miao@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=richard.zhao@linaro.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.