From: Josh Triplett <josh@joshtriplett.org>
To: linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Nick Bowler <nbowler@elliptictech.com>
Subject: Re: [PATCH] checkpatch: Check for quoted strings broken across lines
Date: Thu, 2 Feb 2012 22:34:36 -0800 [thread overview]
Message-ID: <20120203063435.GA15436@leaf> (raw)
In-Reply-To: <20120203052727.GA15035@leaf>
On Thu, Feb 02, 2012 at 09:27:27PM -0800, Josh Triplett wrote:
> checkpatch already makes an exception to the 80-column rule for quoted
> strings, and Documentation/CodingStyle recommends not splitting quoted
> strings across lines, because it breaks the ability to grep for the
> string. Rather than just permitting this, actively warn about quoted
> strings split across lines.
[...]
> v2: Add the "after open parenthesis" heuristic which almost completely
> eliminates non-user-visible strings, leaving only 12 in the entire
> kernel, versus thousands of correct matches. Change "breaks
> greppability" to "breaks the ability to grep for the string".
Sorry, forgot to change "PATCH" to "PATCHv2" in the subject.
- Josh Triplett
next prev parent reply other threads:[~2012-02-03 6:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 5:27 [PATCH] checkpatch: Check for quoted strings broken across lines Josh Triplett
2012-02-03 5:38 ` Joe Perches
2012-02-03 8:55 ` Josh Triplett
2012-02-03 6:34 ` Josh Triplett [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-20 21:06 Josh Triplett
2012-03-21 1:24 ` Joe Perches
2012-03-21 4:28 ` Josh Triplett
2012-03-21 4:35 ` Joe Perches
2012-03-21 6:05 ` Josh Triplett
2012-03-21 12:11 ` Joe Perches
2012-02-02 20:06 Josh Triplett
2012-02-02 20:22 ` Nick Bowler
2012-02-02 21:16 ` Josh Triplett
2012-02-02 22:08 ` Nick Bowler
2012-02-03 1:31 ` Josh Triplett
2012-02-02 21:29 ` Jesper Juhl
2012-02-02 21:34 ` Joe Perches
2012-02-02 22:02 ` Josh Triplett
2012-02-02 20:36 ` Joe Perches
2012-02-02 21:28 ` Josh Triplett
2012-02-02 21:32 ` Joe Perches
2012-02-02 22:36 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203063435.GA15436@leaf \
--to=josh@joshtriplett.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.