From: Josh Triplett <josh@joshtriplett.org>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Check for quoted strings broken across lines
Date: Tue, 20 Mar 2012 23:05:44 -0700 [thread overview]
Message-ID: <20120321060544.GA2831@leaf> (raw)
In-Reply-To: <1332304558.29403.17.camel@joe2Laptop>
On Tue, Mar 20, 2012 at 09:35:58PM -0700, Joe Perches wrote:
> On Tue, 2012-03-20 at 21:28 -0700, Josh Triplett wrote:
> > The heuristics in the patch I submitted almost completely eliminate
> > false positives, which makes my patch suitable for use without --strict.
>
> Yup, this patch is better than the one I submitted.
OK. Andrew, could you substitute my patch for Joe's in your tree?
> One improvement might be to check for a line continuation \
> on $prevline and still produce a warning in that case.
I'd suggest doing that one as a separate check, "unnecessary line
continuation", which should flag any use of a line continuation other
than with a preprocessor directive. I don't think combining that with
the wrapped-string check makes sense.
- Josh Triplett
next prev parent reply other threads:[~2012-03-21 6:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 21:06 [PATCH] checkpatch: Check for quoted strings broken across lines Josh Triplett
2012-03-21 1:24 ` Joe Perches
2012-03-21 4:28 ` Josh Triplett
2012-03-21 4:35 ` Joe Perches
2012-03-21 6:05 ` Josh Triplett [this message]
2012-03-21 12:11 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2012-02-03 5:27 Josh Triplett
2012-02-03 5:38 ` Joe Perches
2012-02-03 8:55 ` Josh Triplett
2012-02-03 6:34 ` Josh Triplett
2012-02-02 20:06 Josh Triplett
2012-02-02 20:22 ` Nick Bowler
2012-02-02 21:16 ` Josh Triplett
2012-02-02 22:08 ` Nick Bowler
2012-02-03 1:31 ` Josh Triplett
2012-02-02 21:29 ` Jesper Juhl
2012-02-02 21:34 ` Joe Perches
2012-02-02 22:02 ` Josh Triplett
2012-02-02 20:36 ` Joe Perches
2012-02-02 21:28 ` Josh Triplett
2012-02-02 21:32 ` Joe Perches
2012-02-02 22:36 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321060544.GA2831@leaf \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.