From: Christoph Hellwig <hch@infradead.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Amit Sahrawat <amit.sahrawat83@gmail.com>,
Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Johannes Weiner <jweiner@redhat.com>,
Amit Sahrawat <a.sahrawat@samsung.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: make do_writepages() use plugging
Date: Fri, 3 Feb 2012 09:08:34 -0500 [thread overview]
Message-ID: <20120203140834.GA15495@infradead.org> (raw)
In-Reply-To: <20120203133823.GB17571@localhost>
On Fri, Feb 03, 2012 at 09:38:23PM +0800, Wu Fengguang wrote:
> On Fri, Feb 03, 2012 at 06:57:06PM +0530, Amit Sahrawat wrote:
> > This will cover all the invocations for writepages to be called with
> > plugging support.
>
> Thanks. I'll test it on the major filesystems. But would you
> name a few filesystems that are expected to benefit from it?
> It's not obvious because some FS ->writepages eventually calls
> generic_writepages() which already does plugging.
Ant that's exactly where it should stay instead of beeing sprinkled all
over the VM code.
NAK to the patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Amit Sahrawat <amit.sahrawat83@gmail.com>,
Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Johannes Weiner <jweiner@redhat.com>,
Amit Sahrawat <a.sahrawat@samsung.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: make do_writepages() use plugging
Date: Fri, 3 Feb 2012 09:08:34 -0500 [thread overview]
Message-ID: <20120203140834.GA15495@infradead.org> (raw)
In-Reply-To: <20120203133823.GB17571@localhost>
On Fri, Feb 03, 2012 at 09:38:23PM +0800, Wu Fengguang wrote:
> On Fri, Feb 03, 2012 at 06:57:06PM +0530, Amit Sahrawat wrote:
> > This will cover all the invocations for writepages to be called with
> > plugging support.
>
> Thanks. I'll test it on the major filesystems. But would you
> name a few filesystems that are expected to benefit from it?
> It's not obvious because some FS ->writepages eventually calls
> generic_writepages() which already does plugging.
Ant that's exactly where it should stay instead of beeing sprinkled all
over the VM code.
NAK to the patch.
next prev parent reply other threads:[~2012-02-03 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 13:27 [PATCH 2/2] mm: make do_writepages() use plugging Amit Sahrawat
2012-02-03 13:27 ` Amit Sahrawat
2012-02-03 13:32 ` Peter Zijlstra
2012-02-03 13:32 ` Peter Zijlstra
2012-02-03 14:01 ` Amit Sahrawat
2012-02-03 14:01 ` Amit Sahrawat
2012-02-03 14:11 ` Amit Sahrawat
2012-02-03 14:11 ` Amit Sahrawat
2012-02-03 13:38 ` Wu Fengguang
2012-02-03 13:38 ` Wu Fengguang
2012-02-03 14:08 ` Christoph Hellwig [this message]
2012-02-03 14:08 ` Christoph Hellwig
2012-02-03 14:21 ` Chris Mason
2012-02-03 14:21 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203140834.GA15495@infradead.org \
--to=hch@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=amit.sahrawat83@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.