From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>, Jamie Iles <jamie@jamieiles.com>,
Stephen Warren <swarren@nvidia.com>,
linux-serial@vger.kernel.org
Subject: Re: [Patch] tty: fix a build failure on sparc
Date: Fri, 3 Feb 2012 14:46:09 -0500 [thread overview]
Message-ID: <20120203194608.GA23948@windriver.com> (raw)
In-Reply-To: <1328246540-5824-1-git-send-email-xiyou.wangcong@gmail.com>
[Resending with updated address for Greg]
On 12-02-03 12:22 AM, Cong Wang wrote:
> On sparc, there is a build failure:
>
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
>
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.
Thanks, I explicitly left sunsu out of the move but missed
that 8250 was sourcing its related header. I did defconfig
builds, but in going back to check, I see that neither sparc
32/64 defconfig enable 8250 by default, so those builds didn't
help me much at all... :(
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index 9f50c4e..9b7336f 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -45,7 +45,7 @@
> #include "8250.h"
>
> #ifdef CONFIG_SPARC
> -#include "suncore.h"
> +#include "../suncore.h"
> #endif
>
> /*
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>, Jamie Iles <jamie@jamieiles.com>,
Stephen Warren <swarren@nvidia.com>,
<linux-serial@vger.kernel.org>
Subject: Re: [Patch] tty: fix a build failure on sparc
Date: Fri, 3 Feb 2012 14:46:09 -0500 [thread overview]
Message-ID: <20120203194608.GA23948@windriver.com> (raw)
In-Reply-To: <1328246540-5824-1-git-send-email-xiyou.wangcong@gmail.com>
[Resending with updated address for Greg]
On 12-02-03 12:22 AM, Cong Wang wrote:
> On sparc, there is a build failure:
>
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
>
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.
Thanks, I explicitly left sunsu out of the move but missed
that 8250 was sourcing its related header. I did defconfig
builds, but in going back to check, I see that neither sparc
32/64 defconfig enable 8250 by default, so those builds didn't
help me much at all... :(
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index 9f50c4e..9b7336f 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -45,7 +45,7 @@
> #include "8250.h"
>
> #ifdef CONFIG_SPARC
> -#include "suncore.h"
> +#include "../suncore.h"
> #endif
>
> /*
next prev parent reply other threads:[~2012-02-03 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 5:22 [Patch] tty: fix a build failure on sparc Cong Wang
2012-02-03 15:53 ` Greg KH
2012-02-03 16:06 ` Paul Gortmaker
2012-02-03 16:06 ` Paul Gortmaker
2012-02-03 19:46 ` Paul Gortmaker [this message]
2012-02-03 19:46 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203194608.GA23948@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.