From: Felipe Balbi <balbi@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
Date: Mon, 06 Feb 2012 06:44:38 +0000 [thread overview]
Message-ID: <20120206064437.GC15652@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20120204133714.GA4413@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
> We always return zero instead of the id we found.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks
> ---
> I don't have this hardware so it's not tested.
This one is so obvious that I can't even believe we haven't seen that
before, thanks ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
Date: Mon, 6 Feb 2012 08:44:38 +0200 [thread overview]
Message-ID: <20120206064437.GC15652@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20120204133714.GA4413@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
> We always return zero instead of the id we found.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks
> ---
> I don't have this hardware so it's not tested.
This one is so obvious that I can't even believe we haven't seen that
before, thanks ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-06 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 13:37 [patch] usb: dwc3: make dwc3_get_device_id() return the id Dan Carpenter
2012-02-04 13:37 ` Dan Carpenter
2012-02-06 6:44 ` Felipe Balbi [this message]
2012-02-06 6:44 ` Felipe Balbi
2012-02-06 8:09 ` walter harms
2012-02-06 8:17 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206064437.GC15652@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.