Re: [PATCH 1/4] tools/flask: remove libflask

[Olaf Hering <olaf@aepfle.de>]

On Fri, Feb 03, Daniel De Graaf wrote:

> This library has been deprecated since July 2010; remove the in-tree
> users and library.

> -	ln -sf libflask.so.$(MAJOR) $(DESTDIR)$(LIBDIR)/libflask.so

> +++ b/tools/python/setup.py
> @@ -48,7 +48,7 @@ flask = Extension("flask",
>                 include_dirs       = [ PATH_XEN, PATH_LIBXC, "xen/lowlevel/flask",
>                                        "../flask/libflask/include" ],
>                 library_dirs       = [ PATH_LIBXC, "../flask/libflask" ],
> -               libraries          = [ "xenctrl", "flask" ],
> +               libraries          = [ "xenctrl" ],
>                 depends            = [ PATH_LIBXC + "/libxenctrl.so",
>                                        XEN_ROOT + "/tools/flask/libflask/libflask.so" ],
>                 sources            = [ "xen/lowlevel/flask/flask.c" ])


For some reason this changeset does not cause buildfailures in automated
testing. My xen-unstable rpm packages fail to build in SLES11, but not in
openSuSE for some reason.

Is there a chance that libflask.so is built after this python thing runs?
In other words: Is there a makefile dependency missing?

Olaf

...
building 'flask' extension
error: ../../tools/flask/libflask/libflask.so: No such file or directory
make[3]: *** [install] Error 1
make[3]: Leaving directory `/usr/src/packages/BUILD/xen-4.2.24701/non-dbg/tools/python'
make[2]: *** [subdir-install-python] Error 2
...