From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 1/4] i2c/gpio-i2c add: add DT support
Date: Tue, 7 Feb 2012 11:25:47 +0000 [thread overview]
Message-ID: <20120207112547.GC3332@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120207025624.GB15647-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Tue, Feb 07, 2012 at 03:56:24AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:09 Mon 06 Feb , Mark Brown wrote:
> > > + - udelay: half clock cycle time in us (may depend on each platform)
> > > + udelay = <2>; /* ~100 kHz */
> > Why not specify this in kHz and do the conversion in the driver? It
> > seems a more intuitive thing to be specifying. I appreciate that the
> > platform data used udelay but it seems an entirely unintuitive thing
> > from a user point of view even if it's what the implementation wants.
> because it's not accurate and on some platform you need to adapt it so we keep
> the udelay
Then you should clarify that in the documentation, it's not the cycle
time but the delay between GPIO operations which isn't quite the same
thing.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] i2c/gpio-i2c add: add DT support
Date: Tue, 7 Feb 2012 11:25:47 +0000 [thread overview]
Message-ID: <20120207112547.GC3332@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120207025624.GB15647@game.jcrosoft.org>
On Tue, Feb 07, 2012 at 03:56:24AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:09 Mon 06 Feb , Mark Brown wrote:
> > > + - udelay: half clock cycle time in us (may depend on each platform)
> > > + udelay = <2>; /* ~100 kHz */
> > Why not specify this in kHz and do the conversion in the driver? It
> > seems a more intuitive thing to be specifying. I appreciate that the
> > platform data used udelay but it seems an entirely unintuitive thing
> > from a user point of view even if it's what the implementation wants.
> because it's not accurate and on some platform you need to adapt it so we keep
> the udelay
Then you should clarify that in the documentation, it's not the cycle
time but the delay between GPIO operations which isn't quite the same
thing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120207/7c9bba3f/attachment.sig>
next prev parent reply other threads:[~2012-02-07 11:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 10:38 [PATCH 1/4] i2c/gpio-i2c add: add DT support Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` [PATCH 2/4] ARM: at91s: sam9g20 add i2c " Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` [PATCH 3/4] ARM: at91: usb_a9g20 add DT i2c support Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` [PATCH 4/4] ARM: at91: sam9g45 add i2c DT support Jean-Christophe PLAGNIOL-VILLARD
2012-02-05 10:38 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1328438337-21185-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-02-06 16:09 ` [PATCH 1/4] i2c/gpio-i2c add: add " Mark Brown
2012-02-06 16:09 ` Mark Brown
[not found] ` <20120206160907.GG10173-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-02-07 2:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-07 2:56 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120207025624.GB15647-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-07 11:25 ` Mark Brown [this message]
2012-02-07 11:25 ` Mark Brown
2012-02-06 18:38 ` Karol Lewandowski
2012-02-06 18:38 ` Karol Lewandowski
[not found] ` <4F301E25.5060507-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-02-06 19:15 ` Jean Delvare
2012-02-06 19:15 ` Jean Delvare
2012-02-07 3:25 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-07 3:25 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120207032533.GC15647-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-07 15:35 ` Karol Lewandowski
2012-02-07 15:35 ` Karol Lewandowski
2012-02-13 23:14 ` Ben Dooks
2012-02-13 23:14 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207112547.GC3332@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.