All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: alsa-devel@alsa-project.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Subject: Re: tea575x-tuner improvements & use in maxiradio
Date: Tue, 7 Feb 2012 23:20:19 +0100	[thread overview]
Message-ID: <201202072320.30911.linux@rainbow-software.org> (raw)
In-Reply-To: <1328447827-9842-1-git-send-email-hverkuil@xs4all.nl>

On Sunday 05 February 2012 14:17:05 Hans Verkuil wrote:
> These patches improve the tea575x-tuner module to make it up to date with
> the latest V4L2 frameworks.
>
> The maxiradio driver has also been converted to use the tea575x-tuner and
> I've used that card to test it.
>
> Unfortunately, this card can't read the data pin, so the new hardware seek
> functionality has been tested only partially (yes, it seeks, but when it
> finds a channel I can't read back the frequency).
>
> Ondrej, are you able to test these patches for the sound cards that use
> this tea575x tuner?
>
> Note that these two patches rely on other work that I did and that hasn't
> been merged yet. So it is best to pull from my git tree:
>
> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/radio-pc
>i2
>
> You can use the v4l-utils repository (http://git.linuxtv.org/v4l-utils.git)
> to test the drivers: the v4l2-compliance test should succeed and with
> v4l2-ctl you can test the hardware seek:
>
> To seek down:
>
> v4l2-ctl -d /dev/radio0 --freq-seek=dir=0
>
> To seek up:
>
> v4l2-ctl -d /dev/radio0 --freq-seek=dir=1
>
> To do the compliance test:
>
> v4l2-compliance -r /dev/radio0

It seems to work (tested with SF64-PCR - snd_fm801) but the seek is severely 
broken. Reading the frequency immediately after seek does not work, it always 
returns the old value (haven't found a delay that works). Reading it later 
(copied back snd_tea575x_get_freq function) works. The chip seeks randomly up 
or down, ignoring UP/DOWN flag and often stops at wrong place (only noise) or 
even outside the FM range.

So I strongly suggest not to enable this (mis-)feature. The HW seems to be 
completely broken (unless there's some weird bug in the code).


-- 
Ondrej Zary

WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Zary <linux@rainbow-software.org>
To: alsa-devel@alsa-project.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Subject: Re: [alsa-devel] tea575x-tuner improvements & use in maxiradio
Date: Tue, 7 Feb 2012 23:20:19 +0100	[thread overview]
Message-ID: <201202072320.30911.linux@rainbow-software.org> (raw)
In-Reply-To: <1328447827-9842-1-git-send-email-hverkuil@xs4all.nl>

On Sunday 05 February 2012 14:17:05 Hans Verkuil wrote:
> These patches improve the tea575x-tuner module to make it up to date with
> the latest V4L2 frameworks.
>
> The maxiradio driver has also been converted to use the tea575x-tuner and
> I've used that card to test it.
>
> Unfortunately, this card can't read the data pin, so the new hardware seek
> functionality has been tested only partially (yes, it seeks, but when it
> finds a channel I can't read back the frequency).
>
> Ondrej, are you able to test these patches for the sound cards that use
> this tea575x tuner?
>
> Note that these two patches rely on other work that I did and that hasn't
> been merged yet. So it is best to pull from my git tree:
>
> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/radio-pc
>i2
>
> You can use the v4l-utils repository (http://git.linuxtv.org/v4l-utils.git)
> to test the drivers: the v4l2-compliance test should succeed and with
> v4l2-ctl you can test the hardware seek:
>
> To seek down:
>
> v4l2-ctl -d /dev/radio0 --freq-seek=dir=0
>
> To seek up:
>
> v4l2-ctl -d /dev/radio0 --freq-seek=dir=1
>
> To do the compliance test:
>
> v4l2-compliance -r /dev/radio0

It seems to work (tested with SF64-PCR - snd_fm801) but the seek is severely 
broken. Reading the frequency immediately after seek does not work, it always 
returns the old value (haven't found a delay that works). Reading it later 
(copied back snd_tea575x_get_freq function) works. The chip seeks randomly up 
or down, ignoring UP/DOWN flag and often stops at wrong place (only noise) or 
even outside the FM range.

So I strongly suggest not to enable this (mis-)feature. The HW seems to be 
completely broken (unless there's some weird bug in the code).


-- 
Ondrej Zary

  parent reply	other threads:[~2012-02-07 22:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05 13:17 tea575x-tuner improvements & use in maxiradio Hans Verkuil
2012-02-05 13:17 ` [RFCv1 PATCH 1/2] tea575x-tuner: update to latest V4L2 framework requirements Hans Verkuil
2012-02-05 13:17   ` [RFCv1 PATCH 2/2] radio-maxiradio: use the tea575x framework Hans Verkuil
2012-02-07 22:20 ` Ondrej Zary [this message]
2012-02-07 22:20   ` [alsa-devel] tea575x-tuner improvements & use in maxiradio Ondrej Zary
2012-02-08  7:29   ` Hans Verkuil
2012-02-08  7:56     ` Ondrej Zary
2012-02-08 19:57     ` Ondrej Zary
2012-02-08 20:30       ` Hans Verkuil
2012-02-08 21:03         ` Ondrej Zary
2012-02-09 22:45     ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202072320.30911.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.