From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/daemons/clvmd clvmd.c
Date: 8 Feb 2012 13:03:40 -0000 [thread overview]
Message-ID: <20120208130340.755.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2012-02-08 13:03:40
Modified files:
daemons/clvmd : clvmd.c
Log message:
A bit more readable code
Just a minor readability conversion.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.119&r2=1.120
--- LVM2/daemons/clvmd/clvmd.c 2012/01/26 17:55:55 1.119
+++ LVM2/daemons/clvmd/clvmd.c 2012/02/08 13:03:40 1.120
@@ -741,8 +741,7 @@
status, sock_client);
/* But has the client gone away ?? */
if (sock_client == NULL) {
- DEBUGLOG
- ("Got PIPE response for dead client, ignoring it\n");
+ DEBUGLOG("Got PIPE response for dead client, ignoring it\n");
} else {
/* If error then just return that code */
if (status)
@@ -751,21 +750,16 @@
else {
/* FIXME: closer inspect this code since state is write thread protected */
pthread_mutex_lock(&sock_client->bits.localsock.mutex);
- if (sock_client->bits.localsock.state ==
- POST_COMMAND) {
+ if (sock_client->bits.localsock.state == POST_COMMAND) {
pthread_mutex_unlock(&sock_client->bits.localsock.mutex);
send_local_reply(sock_client, 0,
sock_client->fd);
- } else // PRE_COMMAND finished.
- {
+ } else {
+ /* PRE_COMMAND finished. */
pthread_mutex_unlock(&sock_client->bits.localsock.mutex);
- if (
- (status =
- distribute_command(sock_client)) !=
- 0) send_local_reply(sock_client,
- EFBIG,
- sock_client->
- fd);
+ if ((status = distribute_command(sock_client)))
+ send_local_reply(sock_client, EFBIG,
+ sock_client->fd);
}
}
}
@@ -1247,9 +1241,8 @@
inheader->node + strlen(inheader->node) + 1;
while (missing_len > 0) {
- DEBUGLOG
- ("got %d bytes, need another %d (total %d)\n",
- argslen, missing_len, inheader->arglen);
+ DEBUGLOG("got %d bytes, need another %d (total %d)\n",
+ argslen, missing_len, inheader->arglen);
len = read(thisfd->fd, argptr + argslen,
missing_len);
if (len == -1 && errno == EINTR)
next reply other threads:[~2012-02-08 13:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 13:03 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 16:59 LVM2/daemons/clvmd clvmd.c mbroz
2012-03-23 9:43 zkabelac
2012-02-28 10:42 zkabelac
2012-02-27 10:17 zkabelac
2012-01-26 17:55 zkabelac
2012-01-25 22:36 zkabelac
2011-10-11 10:06 zkabelac
2011-10-11 9:56 zkabelac
2011-10-11 9:23 zkabelac
2011-10-11 9:18 zkabelac
2011-03-30 12:48 zkabelac
2011-02-28 19:50 zkabelac
2011-01-05 12:17 zkabelac
2010-12-22 14:00 zkabelac
2010-12-20 13:48 zkabelac
2010-11-29 12:44 zkabelac
2010-10-27 11:40 mornfall
2010-10-27 9:13 mornfall
2010-10-26 9:57 zkabelac
2010-10-26 10:46 ` Alasdair G Kergon
2010-10-26 11:05 ` Zdenek Kabelac
2010-11-08 18:37 ` Alasdair G Kergon
2010-10-26 9:01 zkabelac
2010-10-26 10:38 ` Alasdair G Kergon
2009-04-22 10:38 mbroz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208130340.755.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.