From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: LVM2/daemons/clvmd clvmd.c
Date: Tue, 26 Oct 2010 13:05:06 +0200 [thread overview]
Message-ID: <4CC6B5E2.7090003@redhat.com> (raw)
In-Reply-To: <20101026104619.GD29400@agk-dp.fab.redhat.com>
Dne 26.10.2010 12:46, Alasdair G Kergon napsal(a):
> On Tue, Oct 26, 2010 at 09:57:04AM -0000, zkabelac at sourceware.org wrote:
>> +#ifdef __clang__
>> __builtin_unreachable();
>> +#endif
>
> Please do not scatter #ifdefs like that through the code.
> If the standard /* NOTREACHED */ really doesn't work, then hide the
> ifdef in a header file and use a #define to make it available precisely
> where the compiler supports it, defining it to something empty
> elsewhere.
Yes - This patch only provides quick compilation hotfix - and I'll prepare
better solution later.
Zdenek
next prev parent reply other threads:[~2010-10-26 11:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 9:57 LVM2/daemons/clvmd clvmd.c zkabelac
2010-10-26 10:46 ` Alasdair G Kergon
2010-10-26 11:05 ` Zdenek Kabelac [this message]
2010-11-08 18:37 ` Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 16:59 mbroz
2012-03-23 9:43 zkabelac
2012-02-28 10:42 zkabelac
2012-02-27 10:17 zkabelac
2012-02-08 13:03 zkabelac
2012-01-26 17:55 zkabelac
2012-01-25 22:36 zkabelac
2011-10-11 10:06 zkabelac
2011-10-11 9:56 zkabelac
2011-10-11 9:23 zkabelac
2011-10-11 9:18 zkabelac
2011-03-30 12:48 zkabelac
2011-02-28 19:50 zkabelac
2011-01-05 12:17 zkabelac
2010-12-22 14:00 zkabelac
2010-12-20 13:48 zkabelac
2010-11-29 12:44 zkabelac
2010-10-27 11:40 mornfall
2010-10-27 9:13 mornfall
2010-10-26 9:01 zkabelac
2010-10-26 10:38 ` Alasdair G Kergon
2009-04-22 10:38 mbroz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC6B5E2.7090003@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.