From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 15/16] ARM: omap: resolve nebulous 'Error setting wl12xx data'
Date: Wed, 8 Feb 2012 10:56:50 -0800 [thread overview]
Message-ID: <20120208185650.GO29796@atomide.com> (raw)
In-Reply-To: <E1RvAZf-0006Hm-40@rmk-PC.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [120208 08:09]:
> It's useful to print the error code when a called function fails so a
> diagnosis of why it failed is possible. In this case, it fails because
> we try to register some data for the wl12xx driver, but as the driver
> is not configured, a stub function is used which simply returns -ENOSYS.
>
> Let's do the simple thing for -rc and print the error code.
>
> Also, the return code from platform_register_device() at each of these
> sites was not being checked. Add some checking, and again print the
> error code.
>
> This should be fixed properly for the next merge window so we don't
> issue error messages merely because a driver is not configured.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Looks right to me for -rc. Yes let's plan on fixing this for v3.4.
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/16] ARM: omap: resolve nebulous 'Error setting wl12xx data'
Date: Wed, 8 Feb 2012 10:56:50 -0800 [thread overview]
Message-ID: <20120208185650.GO29796@atomide.com> (raw)
In-Reply-To: <E1RvAZf-0006Hm-40@rmk-PC.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [120208 08:09]:
> It's useful to print the error code when a called function fails so a
> diagnosis of why it failed is possible. In this case, it fails because
> we try to register some data for the wl12xx driver, but as the driver
> is not configured, a stub function is used which simply returns -ENOSYS.
>
> Let's do the simple thing for -rc and print the error code.
>
> Also, the return code from platform_register_device() at each of these
> sites was not being checked. Add some checking, and again print the
> error code.
>
> This should be fixed properly for the next merge window so we don't
> issue error messages merely because a driver is not configured.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Looks right to me for -rc. Yes let's plan on fixing this for v3.4.
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2012-02-08 18:56 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:35 [PATCH 00/16] rmk's patch series for fixing OMAP Russell King - ARM Linux
2012-02-08 16:35 ` Russell King - ARM Linux
2012-02-08 16:35 ` Russell King - ARM Linux
2012-02-08 16:36 ` [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Russell King - ARM Linux
2012-02-08 16:36 ` Russell King - ARM Linux
2012-02-08 18:33 ` Tony Lindgren
2012-02-08 18:33 ` Tony Lindgren
2012-02-08 23:46 ` Tony Lindgren
2012-02-08 23:46 ` Tony Lindgren
2012-02-09 16:44 ` Russell King - ARM Linux
2012-02-09 16:44 ` Russell King - ARM Linux
2012-02-09 16:51 ` Tony Lindgren
2012-02-09 16:51 ` Tony Lindgren
2012-02-08 16:36 ` [PATCH 02/16] ARM: omap: fix oops in drivers/video/omap2/dss/dpi.c Russell King - ARM Linux
2012-02-08 16:36 ` Russell King - ARM Linux
2012-02-08 18:36 ` Tony Lindgren
2012-02-08 18:36 ` Tony Lindgren
2012-02-08 22:50 ` Russell King - ARM Linux
2012-02-08 22:50 ` Russell King - ARM Linux
2012-02-08 23:32 ` Tony Lindgren
2012-02-08 23:32 ` Tony Lindgren
2012-02-08 16:36 ` [PATCH 03/16] ARM: omap: fix broken twl-core dependencies and ifdefs Russell King - ARM Linux
2012-02-08 18:38 ` Tony Lindgren
2012-02-08 16:37 ` [PATCH 04/16] ARM: omap: fix prm44xx.c OMAP44XX_IRQ_PRCM build error Russell King - ARM Linux
2012-02-08 16:37 ` Russell King - ARM Linux
2012-02-08 18:39 ` Tony Lindgren
2012-02-08 18:39 ` Tony Lindgren
2012-02-09 18:58 ` Cousson, Benoit
2012-02-09 18:58 ` Cousson, Benoit
2012-02-08 16:37 ` [PATCH 05/16] ARM: omap: fix vc.c PMIC error message Russell King - ARM Linux
2012-02-08 16:37 ` Russell King - ARM Linux
2012-02-08 18:45 ` Tony Lindgren
2012-02-08 18:45 ` Tony Lindgren
2012-02-08 23:06 ` Kevin Hilman
2012-02-08 23:06 ` Kevin Hilman
2012-02-08 23:53 ` Tony Lindgren
2012-02-08 23:53 ` Tony Lindgren
2012-02-08 23:56 ` Russell King - ARM Linux
2012-02-08 23:56 ` Russell King - ARM Linux
2012-02-09 0:09 ` Kevin Hilman
2012-02-09 0:09 ` Kevin Hilman
2012-02-09 0:11 ` Russell King - ARM Linux
2012-02-09 0:11 ` Russell King - ARM Linux
2012-02-09 0:20 ` Kevin Hilman
2012-02-09 0:20 ` Kevin Hilman
2012-02-09 0:40 ` Tony Lindgren
2012-02-09 0:40 ` Tony Lindgren
2012-02-09 16:49 ` Russell King - ARM Linux
2012-02-09 16:49 ` Russell King - ARM Linux
2012-02-09 17:18 ` Tony Lindgren
2012-02-09 17:18 ` Tony Lindgren
2012-02-09 17:27 ` Tony Lindgren
2012-02-09 17:27 ` Tony Lindgren
2012-02-09 17:59 ` Russell King - ARM Linux
2012-02-09 17:59 ` Russell King - ARM Linux
2012-02-09 18:06 ` Tony Lindgren
2012-02-09 18:06 ` Tony Lindgren
2012-02-09 18:46 ` Tony Lindgren
2012-02-09 18:46 ` Tony Lindgren
2012-02-08 23:57 ` Tony Lindgren
2012-02-08 23:57 ` Tony Lindgren
2012-02-09 0:11 ` Kevin Hilman
2012-02-09 0:11 ` Kevin Hilman
2012-02-08 16:37 ` [PATCH 06/16] ARM: omap: fix uninformative vc/i2c configuration " Russell King - ARM Linux
2012-02-08 16:37 ` Russell King - ARM Linux
2012-02-08 18:46 ` Tony Lindgren
2012-02-08 18:46 ` Tony Lindgren
2012-02-08 23:07 ` Kevin Hilman
2012-02-08 23:07 ` Kevin Hilman
2012-02-08 16:38 ` [PATCH 07/16] ARM: omap: fix section mismatch errors in TWL PMIC driver Russell King - ARM Linux
2012-02-08 18:47 ` Tony Lindgren
2012-02-08 16:38 ` [PATCH 08/16] ARM: omap: fix section mismatch warning in mux.c Russell King - ARM Linux
2012-02-08 16:38 ` Russell King - ARM Linux
2012-02-08 18:47 ` Tony Lindgren
2012-02-08 18:47 ` Tony Lindgren
2012-02-08 16:38 ` [PATCH 09/16] ARM: omap: preemptively fix section mismatch in omap4_sdp4430_wifi_mux_init() Russell King - ARM Linux
2012-02-08 16:38 ` Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 10/16] ARM: omap: fix section mismatch warning for omap_secondary_startup() Russell King - ARM Linux
2012-02-08 16:39 ` Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 11/16] ARM: omap: fix section mismatch error for omap_4430sdp_display_init() Russell King - ARM Linux
2012-02-08 16:39 ` Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 12/16] ARM: omap: fix section mismatch warning for sdp3430_twl_gpio_setup() Russell King - ARM Linux
2012-02-08 16:39 ` Russell King - ARM Linux
2012-02-08 18:49 ` Tony Lindgren
2012-02-08 18:49 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 13/16] ARM: omap: fix section mismatch warnings in mux.c caused by hsmmc.c Russell King - ARM Linux
2012-02-08 16:40 ` Russell King - ARM Linux
2012-02-08 18:50 ` Tony Lindgren
2012-02-08 18:50 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 14/16] ARM: omap: fix wrapped error messages in omap_hwmod.c Russell King - ARM Linux
2012-02-08 16:40 ` Russell King - ARM Linux
2012-02-08 17:40 ` Paul Walmsley
2012-02-08 17:40 ` Paul Walmsley
2012-02-08 18:54 ` Tony Lindgren
2012-02-08 18:54 ` Tony Lindgren
2012-02-08 19:25 ` Paul Walmsley
2012-02-08 19:25 ` Paul Walmsley
2012-02-08 19:31 ` Tony Lindgren
2012-02-08 19:31 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 15/16] ARM: omap: resolve nebulous 'Error setting wl12xx data' Russell King - ARM Linux
2012-02-08 16:40 ` Russell King - ARM Linux
2012-02-08 18:56 ` Tony Lindgren [this message]
2012-02-08 18:56 ` Tony Lindgren
2012-02-08 16:41 ` [PATCH 16/16] ARM: omap: disable cpuidle for OMAP3 platforms Russell King - ARM Linux
2012-02-08 16:41 ` Russell King - ARM Linux
2012-02-08 18:59 ` Tony Lindgren
2012-02-08 18:59 ` Tony Lindgren
2012-02-08 22:59 ` Russell King - ARM Linux
2012-02-08 22:59 ` Russell King - ARM Linux
2012-02-08 23:09 ` Kevin Hilman
2012-02-08 23:09 ` Kevin Hilman
2012-02-08 23:30 ` Kevin Hilman
2012-02-08 23:30 ` Kevin Hilman
2012-02-08 19:06 ` [PATCH 00/16] rmk's patch series for fixing OMAP Tony Lindgren
2012-02-08 19:06 ` Tony Lindgren
2012-02-08 19:06 ` Tony Lindgren
2012-02-08 20:31 ` Florian Tobias Schandinat
2012-02-08 20:31 ` Florian Tobias Schandinat
2012-02-08 20:31 ` Florian Tobias Schandinat
2012-02-09 0:53 ` Russell King - ARM Linux
2012-02-09 0:53 ` Russell King - ARM Linux
2012-02-09 0:53 ` Russell King - ARM Linux
2012-02-09 7:02 ` Tomi Valkeinen
2012-02-09 7:02 ` Tomi Valkeinen
2012-02-09 7:02 ` Tomi Valkeinen
2012-02-09 8:30 ` Teresa Gamez
2012-02-09 8:30 ` Teresa Gamez
2012-02-09 8:30 ` Teresa Gamez
2012-02-09 10:24 ` Tomi Valkeinen
2012-02-09 10:24 ` Tomi Valkeinen
2012-02-09 10:24 ` Tomi Valkeinen
2012-02-09 18:00 ` [PATCH 01] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Russell King - ARM Linux
2012-02-09 18:00 ` Russell King - ARM Linux
2012-02-09 18:01 ` [PATCH 05] ARM: omap: fix vc.c PMIC error message Russell King - ARM Linux
2012-02-09 18:01 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208185650.GO29796@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.