All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Anton Blanchard <anton@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	emunson@mgebm.net, imunsie@au1.ibm.com, eranian@google.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf annotate: Numeric assembly labels cause incorrect annotation
Date: Thu, 9 Feb 2012 14:31:02 +0100	[thread overview]
Message-ID: <20120209133101.GC8830@elte.hu> (raw)
In-Reply-To: <1328782223.9303.3.camel@marge.simpson.net>


* Mike Galbraith <efault@gmx.de> wrote:

> On Tue, 2012-02-07 at 12:40 -0200, Arnaldo Carvalho de Melo wrote: 
> > Em Tue, Feb 07, 2012 at 02:55:35PM +1100, Anton Blanchard escreveu:
> > > 
> > > A perf annotate of a kernel function written in assembly shows
> > > very strange percentages:
> > 
> > Thanks! I think this is the same problem Mike Galbraith noticed and
> > reported me (I guess that was in a private message), Mike, can you
> > please test it so that I can add more Foo-by stamps to this one?
> 
> Sorry for the slow response (bz bz).
> 
> I don't see that problem, but perf top annotation isn't 
> working properly in tip at least.  It seems to have forgotten 
> how to average, seems to be clearing hit counts at every 
> screen refresh or something.

hm, seems to work fine here. We used to have such a bug recently 
(as of a few weeks [days?] ago), but latest -tip does not show 
those symptoms.

Thanks,

	Ingo

  reply	other threads:[~2012-02-09 13:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07  3:55 [PATCH] perf annotate: Numeric assembly labels cause incorrect annotation Anton Blanchard
2012-02-07 14:25 ` Eric B Munson
2012-02-07 14:40 ` Arnaldo Carvalho de Melo
2012-02-09 10:10   ` Mike Galbraith
2012-02-09 13:31     ` Ingo Molnar [this message]
2012-02-09 14:50       ` Mike Galbraith
2012-02-09 15:50       ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120209133101.GC8830@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=anton@samba.org \
    --cc=efault@gmx.de \
    --cc=emunson@mgebm.net \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.