From: Tony Lindgren <tony@atomide.com>
To: "Bedia, Vaibhav" <vaibhav.bedia@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"enli.chan@gmail.com" <enli.chan@gmail.com>
Subject: Re: Incorrect Register Offsets in OMAP Mailbox
Date: Thu, 9 Feb 2012 09:47:10 -0800 [thread overview]
Message-ID: <20120209174709.GH1426@atomide.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433179B3F8@DBDE01.ent.ti.com>
* Bedia, Vaibhav <vaibhav.bedia@ti.com> [120209 02:54]:
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Henry Chan
> > Sent: Tuesday, February 07, 2012 11:27 PM
> > To: linux-omap@vger.kernel.org
> > Subject: Incorrect Register Offsets in OMAP Mailbox
> >
> > Hi,
> >
> > Looks like the register offsets are incorrect in the OMAP mailbox code
> > (arch/arm/mach-omap2/mailbox.c) for the OMAP4_MAILBOX_IRQ* macros. The
> > discrepancy is with p.224 of TI document SPRUGX9 and p3891 of SWPU231K.
> > Patch attached.
> >
> > My hardware hasn't come in yet, so I would appreciate it if anyone can
> > share their experience using this code.
> >
>
> Yes, this change is required. Other than this fix the code is fine IMO.
>
> I guess the address calculation macros can be simplified to match with the
> terminology used in the TRM. I'll submit a patch for that once I manage to
> get some time for doing it right.
Care to reply with Acked-by/Tested-by so I can queue this into fixes?
Regards,
Tony
next prev parent reply other threads:[~2012-02-09 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <331ABD5ECB02734CA317220B2BBEABC1317897C8@DBDE01.ent.ti.com>
2012-02-09 11:25 ` Incorrect Register Offsets in OMAP Mailbox Bedia, Vaibhav
2012-02-09 17:47 ` Tony Lindgren [this message]
2012-02-09 17:58 ` Bedia, Vaibhav
2012-02-10 1:14 ` Tony Lindgren
2012-02-10 4:25 ` Bedia, Vaibhav
2012-02-07 17:57 Henry Chan
2012-03-05 19:34 ` Tony Lindgren
2012-03-08 8:04 ` Henry Chan
2012-05-04 18:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209174709.GH1426@atomide.com \
--to=tony@atomide.com \
--cc=enli.chan@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.