All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henry Chan <enli.chan@gmail.com>
To: linux-omap@vger.kernel.org
Subject: Incorrect Register Offsets in OMAP Mailbox
Date: Tue, 07 Feb 2012 09:57:04 -0800	[thread overview]
Message-ID: <4F3165F0.2010306@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi,

Looks like the register offsets are incorrect in the OMAP mailbox code
(arch/arm/mach-omap2/mailbox.c) for the OMAP4_MAILBOX_IRQ* macros. The
discrepancy is with p.224 of TI document SPRUGX9 and p3891 of SWPU231K.
Patch attached.

My hardware hasn't come in yet, so I would appreciate it if anyone can
share their experience using this code.

Thanks.
-H
-- 
Henry Chan

[-- Attachment #2: 0001-Fix-mailbox-IRQ-offsets.patch --]
[-- Type: text/x-patch, Size: 841 bytes --]

 arch/arm/mach-omap2/mailbox.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index 609ea2d..4801e01 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -26,9 +26,9 @@
 #define MAILBOX_IRQSTATUS(u)		(0x100 + 8 * (u))
 #define MAILBOX_IRQENABLE(u)		(0x104 + 8 * (u))
 
-#define OMAP4_MAILBOX_IRQSTATUS(u)	(0x104 + 10 * (u))
-#define OMAP4_MAILBOX_IRQENABLE(u)	(0x108 + 10 * (u))
-#define OMAP4_MAILBOX_IRQENABLE_CLR(u)	(0x10c + 10 * (u))
+#define OMAP4_MAILBOX_IRQSTATUS(u)	(0x104 + 0x10 * (u))
+#define OMAP4_MAILBOX_IRQENABLE(u)	(0x108 + 0x10 * (u))
+#define OMAP4_MAILBOX_IRQENABLE_CLR(u)	(0x10c + 0x10 * (u))
 
 #define MAILBOX_IRQ_NEWMSG(m)		(1 << (2 * (m)))
 #define MAILBOX_IRQ_NOTFULL(m)		(1 << (2 * (m) + 1))


[-- Attachment #3: enli_chan.vcf --]
[-- Type: text/x-vcard, Size: 142 bytes --]

begin:vcard
fn:Henry Chan
n:Chan;Henry
email;internet:enli.chan@gmail.com
tel;cell:(315) 834-2426
x-mozilla-html:FALSE
version:2.1
end:vcard


             reply	other threads:[~2012-02-07 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 17:57 Henry Chan [this message]
2012-03-05 19:34 ` Incorrect Register Offsets in OMAP Mailbox Tony Lindgren
2012-03-08  8:04   ` Henry Chan
2012-05-04 18:07     ` Tony Lindgren
     [not found] <331ABD5ECB02734CA317220B2BBEABC1317897C8@DBDE01.ent.ti.com>
2012-02-09 11:25 ` Bedia, Vaibhav
2012-02-09 17:47   ` Tony Lindgren
2012-02-09 17:58     ` Bedia, Vaibhav
2012-02-10  1:14       ` Tony Lindgren
2012-02-10  4:25         ` Bedia, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3165F0.2010306@gmail.com \
    --to=enli.chan@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.