From: Arnd Bergmann <arnd@arndb.de>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
olof@lixom.net, Thomas Abraham <thomas.abraham@linaro.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 6/9] serial: samsung: Add support for EXYNOS5250
Date: Thu, 9 Feb 2012 23:41:08 +0000 [thread overview]
Message-ID: <201202092341.08981.arnd@arndb.de> (raw)
In-Reply-To: <CAH9JG2XE7nj1je9SYQ=zJKo0_P5Sx_ruZrDjtpnsL0Qtvzb+_Q@mail.gmail.com>
On Wednesday 01 February 2012, Kyungmin Park wrote:
> >
> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> > index 3b07fb9..c55e5fb 100644
> > --- a/drivers/tty/serial/samsung.c
> > +++ b/drivers/tty/serial/samsung.c
> > @@ -1594,7 +1594,7 @@ static struct s3c24xx_serial_drv_data
> > s5pv210_serial_drv_data = {
> > #endif
> >
> > #if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \
> > - defined(CONFIG_SOC_EXYNOS4412)
> > + defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250)
> I think you can make it simple just use "#ifdef CONFIG_ARCH_EXYNOS "
Or you could just remove all the #ifdef. Most drivers just register
for all devices that they support, even if you know which one to expect.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] serial: samsung: Add support for EXYNOS5250
Date: Thu, 9 Feb 2012 23:41:08 +0000 [thread overview]
Message-ID: <201202092341.08981.arnd@arndb.de> (raw)
In-Reply-To: <CAH9JG2XE7nj1je9SYQ=zJKo0_P5Sx_ruZrDjtpnsL0Qtvzb+_Q@mail.gmail.com>
On Wednesday 01 February 2012, Kyungmin Park wrote:
> >
> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> > index 3b07fb9..c55e5fb 100644
> > --- a/drivers/tty/serial/samsung.c
> > +++ b/drivers/tty/serial/samsung.c
> > @@ -1594,7 +1594,7 @@ static struct s3c24xx_serial_drv_data
> > s5pv210_serial_drv_data = {
> > #endif
> >
> > #if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \
> > - defined(CONFIG_SOC_EXYNOS4412)
> > + defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250)
> I think you can make it simple just use "#ifdef CONFIG_ARCH_EXYNOS "
Or you could just remove all the #ifdef. Most drivers just register
for all devices that they support, even if you know which one to expect.
Arnd
next prev parent reply other threads:[~2012-02-09 23:41 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 15:39 [PATCH 0/9] ARM: EXYNOS: add support EXYNOS5 SoC Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 1/9] ARM: EXYNOS: use exynos_init_uarts() instead of exynos4_init_uarts() Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 3:57 ` Kyungmin Park
2012-02-01 3:57 ` Kyungmin Park
2012-02-09 10:30 ` Kukjin Kim
2012-02-09 10:30 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 2/9] ARM: EXYNOS: add clock part for EXYNOS5250 SoC Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 4:08 ` Kyungmin Park
2012-02-01 4:08 ` Kyungmin Park
2012-02-09 10:50 ` Kukjin Kim
2012-02-09 10:50 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 3/9] ARM: EXYNOS: add initial setup-i2c0 for EXYNOS5 Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 4:10 ` Kyungmin Park
2012-02-01 4:10 ` Kyungmin Park
2012-02-09 10:56 ` Kukjin Kim
2012-02-09 10:56 ` Kukjin Kim
2012-02-01 8:53 ` Olof Johansson
2012-02-01 8:53 ` Olof Johansson
2012-02-09 11:39 ` Kukjin Kim
2012-02-09 11:39 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 4/9] ARM: EXYNOS: add support for ARCH_EXYNOS5 and EXYNOS5250 Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 4:18 ` Kyungmin Park
2012-02-01 4:18 ` Kyungmin Park
2012-02-09 11:12 ` Kukjin Kim
2012-02-09 11:12 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250 Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 4:20 ` Kyungmin Park
2012-02-01 4:20 ` Kyungmin Park
2012-02-01 8:50 ` Olof Johansson
2012-02-01 8:50 ` Olof Johansson
2012-02-01 9:34 ` Will Deacon
2012-02-01 9:34 ` Will Deacon
2012-02-09 11:31 ` Kukjin Kim
2012-02-09 11:31 ` Kukjin Kim
2012-02-09 23:36 ` Arnd Bergmann
2012-02-09 23:36 ` Arnd Bergmann
2012-01-31 15:39 ` [PATCH 6/9] serial: samsung: Add support for EXYNOS5250 Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 4:21 ` Kyungmin Park
2012-02-01 4:21 ` Kyungmin Park
2012-02-09 11:32 ` Kukjin Kim
2012-02-09 11:32 ` Kukjin Kim
2012-02-09 23:41 ` Arnd Bergmann [this message]
2012-02-09 23:41 ` Arnd Bergmann
2012-01-31 15:39 ` [PATCH 7/9] ARM: EXYNOS: temporary add interrupt definitions Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 8/9] ARM: EXYNOS: temporary add map definitions for uart Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 5:53 ` Kyungmin Park
2012-02-01 5:53 ` Kyungmin Park
2012-02-10 8:35 ` Kukjin Kim
2012-02-10 8:35 ` Kukjin Kim
2012-01-31 15:39 ` [PATCH 9/9] ARM: EXYNOS: temporary fixup regarding get_core_count() Kukjin Kim
2012-01-31 15:39 ` Kukjin Kim
2012-02-01 5:58 ` Kyungmin Park
2012-02-01 5:58 ` Kyungmin Park
2012-02-10 10:16 ` Kukjin Kim
2012-02-10 10:16 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202092341.08981.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=kgene.kim@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.