All of lore.kernel.org
 help / color / mirror / Atom feed
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: hex number case in dts files.
Date: Thu, 9 Feb 2012 16:29:50 -0800	[thread overview]
Message-ID: <20120210002950.GA18408@codeaurora.org> (raw)
In-Reply-To: <20120210001921.GA10536@truffala.fritz.box>

On Fri, Feb 10, 2012 at 11:19:21AM +1100, David Gibson wrote:
> On Thu, Feb 09, 2012 at 12:20:33PM -0600, Rob Herring wrote:
> > On 02/09/2012 12:04 PM, David Brown wrote:
> > > I've noticed an inconsistency in the case of letters in hex constants
> > > in various dts files.  The ones that are actually numbers probably
> > > don't really matter, the but the node names are case sensitive
> > > strings, and in some sense do matter.
> > > 
> > > I ask because some people I've spoken with internally seem to have
> > > strong opinions about what case hex constants should be, and it'd be
> > > nice to be able to have some guideline about this.  Historically, I've
> > > always seen DT hex values in lowercase.
> > > 
> > 
> > Lower case should be used for dts files.
> 
> Yes, the node names should always have the hex done in lower case.  I
> have plans to put more checks in for how reg is encoded into node
> names, but just need to get time.

What about number of digits?  Should a register at 0x42 be
node at 00000042 or node at 42?  Again, I'm seeing both.

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: hex number case in dts files.
Date: Thu, 9 Feb 2012 16:29:50 -0800	[thread overview]
Message-ID: <20120210002950.GA18408@codeaurora.org> (raw)
In-Reply-To: <20120210001921.GA10536-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>

On Fri, Feb 10, 2012 at 11:19:21AM +1100, David Gibson wrote:
> On Thu, Feb 09, 2012 at 12:20:33PM -0600, Rob Herring wrote:
> > On 02/09/2012 12:04 PM, David Brown wrote:
> > > I've noticed an inconsistency in the case of letters in hex constants
> > > in various dts files.  The ones that are actually numbers probably
> > > don't really matter, the but the node names are case sensitive
> > > strings, and in some sense do matter.
> > > 
> > > I ask because some people I've spoken with internally seem to have
> > > strong opinions about what case hex constants should be, and it'd be
> > > nice to be able to have some guideline about this.  Historically, I've
> > > always seen DT hex values in lowercase.
> > > 
> > 
> > Lower case should be used for dts files.
> 
> Yes, the node names should always have the hex done in lower case.  I
> have plans to put more checks in for how reg is encoded into node
> names, but just need to get time.

What about number of digits?  Should a register at 0x42 be
node@00000042 or node@42?  Again, I'm seeing both.

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2012-02-10  0:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 18:04 hex number case in dts files David Brown
2012-02-09 18:04 ` David Brown
2012-02-09 18:20 ` Rob Herring
2012-02-09 18:20   ` Rob Herring
2012-02-10  0:19   ` David Gibson
2012-02-10  0:19     ` David Gibson
2012-02-10  0:29     ` David Brown [this message]
2012-02-10  0:29       ` David Brown
2012-02-10  1:25       ` David Gibson
2012-02-10  1:25         ` David Gibson
2012-02-10 17:25       ` Segher Boessenkool
2012-02-10 17:25         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120210002950.GA18408@codeaurora.org \
    --to=davidb@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.