From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Cc: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V1] regmap: Support for caching in reg_raw_write()
Date: Fri, 10 Feb 2012 12:14:05 +0000 [thread overview]
Message-ID: <20120210121405.GD6472@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F350716.9050407-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Fri, Feb 10, 2012 at 01:01:26PM +0100, Lars-Peter Clausen wrote:
> In my opinion it makes more sense to introduce a regmap_bulk_write function
> for this. regmap_raw_write was not really meant to write registers but
This isn't exclusive to that, I think Laxman planned to send a patch
doing that on top of this one which would be what most users would end
up using.
> rather binary blobs, like firmware. Also this keeps things consistent with
> the read part of the regmap API.
See the previous discussion on this in the past day or so - bulk_write()
is more complicated to implement by itself since it's going to end up
boling down to a raw_write() internally anyway (as does reg_write()) and
it seems nicer to just do the right thing if people ask for it.
We can always refactor later to improve performance if needed but this
is a simple starting point.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V1] regmap: Support for caching in reg_raw_write()
Date: Fri, 10 Feb 2012 12:14:05 +0000 [thread overview]
Message-ID: <20120210121405.GD6472@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F350716.9050407@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Fri, Feb 10, 2012 at 01:01:26PM +0100, Lars-Peter Clausen wrote:
> In my opinion it makes more sense to introduce a regmap_bulk_write function
> for this. regmap_raw_write was not really meant to write registers but
This isn't exclusive to that, I think Laxman planned to send a patch
doing that on top of this one which would be what most users would end
up using.
> rather binary blobs, like firmware. Also this keeps things consistent with
> the read part of the regmap API.
See the previous discussion on this in the past day or so - bulk_write()
is more complicated to implement by itself since it's going to end up
boling down to a raw_write() internally anyway (as does reg_write()) and
it seems nicer to just do the right thing if people ask for it.
We can always refactor later to improve performance if needed but this
is a simple starting point.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-10 12:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 11:32 [PATCH V1] regmap: Support for caching in reg_raw_write() Laxman Dewangan
2012-02-10 11:32 ` Laxman Dewangan
[not found] ` <1328873572-12603-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-02-10 11:45 ` Mark Brown
2012-02-10 11:45 ` Mark Brown
2012-02-10 12:01 ` Lars-Peter Clausen
[not found] ` <4F350716.9050407-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2012-02-10 12:07 ` Laxman Dewangan
2012-02-10 12:07 ` Laxman Dewangan
2012-02-10 12:14 ` Mark Brown [this message]
2012-02-10 12:14 ` Mark Brown
[not found] ` <20120210121405.GD6472-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-02-10 12:33 ` Lars-Peter Clausen
2012-02-10 12:33 ` Lars-Peter Clausen
[not found] ` <4F350E8C.6030907-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2012-02-10 15:58 ` Mark Brown
2012-02-10 15:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210121405.GD6472@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.