All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	'Ben Dooks' <ben-linux@fluff.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: s3c2440:  fix undefined reference to `s3c2440_restart' for machine gta02
Date: Sun, 12 Feb 2012 14:57:17 +0100	[thread overview]
Message-ID: <201202121457.18632.heiko@sntech.de> (raw)
In-Reply-To: <1329051929-8303-1-git-send-email-GNUtoo@no-log.org>

Hi Denis,

Am Sonntag 12 Februar 2012, 14:05:29 schrieb Denis 'GNUtoo' Carikli:
> Without that fix we have(when compiling for the gta02 machine):
>     LD      .tmp_vmlinux1
>   arch/arm/mach-s3c2440/built-in.o:(.arch.info.init+0x3c): undefined
> reference to `s3c2440_restart' make: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> ---
>  arch/arm/mach-s3c2440/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
> index 914e620..d8c8ad7 100644
> --- a/arch/arm/mach-s3c2440/Kconfig
> +++ b/arch/arm/mach-s3c2440/Kconfig
> @@ -89,6 +89,7 @@ config MACH_ANUBIS
>  config MACH_NEO1973_GTA02
>  	bool "Openmoko GTA02 / Freerunner phone"
>  	select CPU_S3C2442
> +	select CPU_S3C2440
>  	select MFD_PCF50633
>  	select PCF50633_GPIO
>  	select I2C
wouldn't moving the restart function to common code be better than selecting a 
cpu that is not used?

I've also added the relevant maintainers to the mail.

Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c2440: fix undefined reference to `s3c2440_restart' for machine gta02
Date: Sun, 12 Feb 2012 14:57:17 +0100	[thread overview]
Message-ID: <201202121457.18632.heiko@sntech.de> (raw)
In-Reply-To: <1329051929-8303-1-git-send-email-GNUtoo@no-log.org>

Hi Denis,

Am Sonntag 12 Februar 2012, 14:05:29 schrieb Denis 'GNUtoo' Carikli:
> Without that fix we have(when compiling for the gta02 machine):
>     LD      .tmp_vmlinux1
>   arch/arm/mach-s3c2440/built-in.o:(.arch.info.init+0x3c): undefined
> reference to `s3c2440_restart' make: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> ---
>  arch/arm/mach-s3c2440/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
> index 914e620..d8c8ad7 100644
> --- a/arch/arm/mach-s3c2440/Kconfig
> +++ b/arch/arm/mach-s3c2440/Kconfig
> @@ -89,6 +89,7 @@ config MACH_ANUBIS
>  config MACH_NEO1973_GTA02
>  	bool "Openmoko GTA02 / Freerunner phone"
>  	select CPU_S3C2442
> +	select CPU_S3C2440
>  	select MFD_PCF50633
>  	select PCF50633_GPIO
>  	select I2C
wouldn't moving the restart function to common code be better than selecting a 
cpu that is not used?

I've also added the relevant maintainers to the mail.

Heiko

  reply	other threads:[~2012-02-12 13:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-12 13:05 [PATCH] ARM: s3c2440: fix undefined reference to `s3c2440_restart' for machine gta02 Denis 'GNUtoo' Carikli
2012-02-12 13:57 ` Heiko Stübner [this message]
2012-02-12 13:57   ` Heiko Stübner
2012-02-12 13:59   ` [PATCH] ARM: S3C24XX: Fix restart on S3C2442 Heiko Stübner
2012-02-12 13:59     ` Heiko Stübner
2012-02-12 18:57     ` Denis 'GNUtoo' Carikli
2012-02-12 18:57       ` Denis 'GNUtoo' Carikli
2012-02-13 12:29       ` Denis 'GNUtoo' Carikli
2012-02-13 12:29         ` Denis 'GNUtoo' Carikli
2012-02-13 12:58         ` Heiko Stübner
2012-02-13 12:58           ` Heiko Stübner
2012-02-16  7:43     ` Heiko Stübner
2012-02-16  7:43       ` Heiko Stübner
2012-02-16 12:00       ` Kukjin Kim
2012-02-16 12:00         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202121457.18632.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=GNUtoo@no-log.org \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.