[Qemu-devel] [PATCH] Running vgabios during resume from S3 on QEMU by default

[Qemu-devel] [PATCH] Running vgabios during resume from S3 on QEMU by default

[Gleb Natapov]

Run vgabios during resume from S3 by default on QEMU. QEMU
still able to modify SeaBIOS behavior if it wishes so by providing
etc/s3-resume-vga-init file. With QEMU emulated vga cards this behaviour
is desirable otherwise console becomes unusable with Linux guests after
resume. Since we control vgabios source we can be sure that running it
on resume from S3 is safe.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
---

Older versions of SeaBIOS had a runtime configure option (disabled by
default) to enable this behaviour and RHEL always enabled it, so this
code path is well tested.  But QEMU upstream always compiled SeaBIOS
with default options and hence this patch will modify upstream
behaviour. Are there any objections to this change from QEMU side?

diff --git a/src/optionroms.c b/src/optionroms.c
index 27cfffd..06db1c1 100644
--- a/src/optionroms.c
+++ b/src/optionroms.c
@@ -423,7 +423,7 @@ vga_setup(void)
 
     // Load some config settings that impact VGA.
     EnforceChecksum = romfile_loadint("etc/optionroms-checksum", 1);
-    S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", 0);
+    S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", !CONFIG_COREBOOT);
     ScreenAndDebug = romfile_loadint("etc/screen-and-debug", 1);
 
     if (CONFIG_OPTIONROMS_DEPLOYED) {
--
			Gleb.

Re: [Qemu-devel] [PATCH] Running vgabios during resume from S3 on QEMU by default

[Kevin O'Connor]

On Mon, Feb 13, 2012 at 01:01:07PM +0200, Gleb Natapov wrote:
> Run vgabios during resume from S3 by default on QEMU. QEMU
> still able to modify SeaBIOS behavior if it wishes so by providing
> etc/s3-resume-vga-init file. With QEMU emulated vga cards this behaviour
> is desirable otherwise console becomes unusable with Linux guests after
> resume. Since we control vgabios source we can be sure that running it
> on resume from S3 is safe.

Thanks - I committed this change.

-Kevin