From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: remove an unneeded NULL check
Date: Mon, 13 Feb 2012 23:39:17 +0000 [thread overview]
Message-ID: <20120213233917.GI21641@thunk.org> (raw)
In-Reply-To: <20120124084109.GC29097@elgon.mountain>
On Tue, Jan 24, 2012 at 11:41:09AM +0300, Dan Carpenter wrote:
> We dereference "bh" unconditionally a couple lines down to find
> "by->b_size". This function is never called with a NULL "bh" so I have
> removed the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: remove an unneeded NULL check
Date: Mon, 13 Feb 2012 18:39:17 -0500 [thread overview]
Message-ID: <20120213233917.GI21641@thunk.org> (raw)
In-Reply-To: <20120124084109.GC29097@elgon.mountain>
On Tue, Jan 24, 2012 at 11:41:09AM +0300, Dan Carpenter wrote:
> We dereference "bh" unconditionally a couple lines down to find
> "by->b_size". This function is never called with a NULL "bh" so I have
> removed the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2012-02-13 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 8:41 [patch] ext4: remove an unneeded NULL check Dan Carpenter
2012-01-24 8:41 ` Dan Carpenter
2012-02-13 23:39 ` Ted Ts'o [this message]
2012-02-13 23:39 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213233917.GI21641@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.