All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Luciano Coelho <coelho@ti.com>
Cc: linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
Date: Tue, 14 Feb 2012 12:38:01 -0800	[thread overview]
Message-ID: <20120214203801.GU1426@atomide.com> (raw)
In-Reply-To: <1328699683-19357-1-git-send-email-coelho@ti.com>

* Luciano Coelho <coelho@ti.com> [120208 02:43]:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> 
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> 
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined.  This problem was introduced in commit
> 2f31b51 (ARM: OMAP4: PRM: use PRCM interrupt handler).
> 
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>

A similar patch should be already in mainline kernel queued by Russell.

Tony

> ---
> v2: changed the commit log to use abbrev sha and include the commit subject
> 
>  arch/arm/mach-omap2/prm44xx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
>  #include "common.h"
>  #include <plat/cpu.h>
>  #include <plat/prcm.h>
> +#include <plat/irqs.h>
>  
>  #include "vp.h"
>  #include "prm44xx.h"
> -- 
> 1.7.5.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
Date: Tue, 14 Feb 2012 12:38:01 -0800	[thread overview]
Message-ID: <20120214203801.GU1426@atomide.com> (raw)
In-Reply-To: <1328699683-19357-1-git-send-email-coelho@ti.com>

* Luciano Coelho <coelho@ti.com> [120208 02:43]:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> 
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> 
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined.  This problem was introduced in commit
> 2f31b51 (ARM: OMAP4: PRM: use PRCM interrupt handler).
> 
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>

A similar patch should be already in mainline kernel queued by Russell.

Tony

> ---
> v2: changed the commit log to use abbrev sha and include the commit subject
> 
>  arch/arm/mach-omap2/prm44xx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
>  #include "common.h"
>  #include <plat/cpu.h>
>  #include <plat/prcm.h>
> +#include <plat/irqs.h>
>  
>  #include "vp.h"
>  #include "prm44xx.h"
> -- 
> 1.7.5.4
> 

  reply	other threads:[~2012-02-14 20:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 11:14 [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined Luciano Coelho
2012-02-08 11:14 ` Luciano Coelho
2012-02-14 20:38 ` Tony Lindgren [this message]
2012-02-14 20:38   ` Tony Lindgren
2012-02-15  7:20   ` Luciano Coelho
2012-02-15  7:20     ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120214203801.GU1426@atomide.com \
    --to=tony@atomide.com \
    --cc=coelho@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.