From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kai Bankett <chaosman@ontika.net>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] qnx4fs: small cleanup #2
Date: Thu, 16 Feb 2012 10:09:33 +0000 [thread overview]
Message-ID: <20120216100933.GK23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4F3C3399.7090407@ontika.net>
On Wed, Feb 15, 2012 at 11:37:13PM +0100, Kai Bankett wrote:
> rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE);
> - if (rootdir->di_fname != NULL) {
> + if (!rootdir->di_fname) {
Huh???
a) this actually inverts the test
b) ->di_fname is actually an array; the test made no
sense even before that change; it's _never_ NULL. See commit
1aab323ea5cd67d2d2572a1f2794978583ff8545 in -rc1...
next prev parent reply other threads:[~2012-02-16 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 1:43 [PATCH] qnx4fs: small cleanup Kai Bankett
2012-02-14 4:00 ` Al Viro
2012-02-15 2:58 ` Kai Bankett
2012-02-15 22:37 ` [PATCH] qnx4fs: small cleanup #2 Kai Bankett
2012-02-16 10:09 ` Al Viro [this message]
2012-02-16 17:46 ` Kai Bankett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216100933.GK23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chaosman@ontika.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.