From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Russell King <rmk+kernel@arm.linux.org.uk>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins
Date: Thu, 16 Feb 2012 08:45:05 -0800 [thread overview]
Message-ID: <20120216164504.GD15692@atomide.com> (raw)
In-Reply-To: <20120215182825.18884.40972.stgit@kaulin.local>
* Tony Lindgren <tony@atomide.com> [120215 09:57]:
>
> +void omap_hsmmc_late_init(struct omap2_hsmmc_info *controllers)
> +{
> + struct platform_device *pdev;
> + int res;
> +
> + for (; controllers->mmc; controllers++) {
> + if (!controllers->deferred)
> + continue;
> +
> + pdev = controllers->pdev;
> + if (!pdev)
> + continue;
> +
> + res = omap_device_register(pdev);
> + if (res) {
> + pr_err("Could not late init MMC %s\n",
> + controllers->name);
> + continue;
> + }
> + }
> +}
Most likely there's no need to pass struct omap2_hsmmc_info *controllers
to omap_hsmmc_late_init() here. And I'll also take a look at making
it a completion to make it more generic across various PMICs.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins
Date: Thu, 16 Feb 2012 08:45:05 -0800 [thread overview]
Message-ID: <20120216164504.GD15692@atomide.com> (raw)
In-Reply-To: <20120215182825.18884.40972.stgit@kaulin.local>
* Tony Lindgren <tony@atomide.com> [120215 09:57]:
>
> +void omap_hsmmc_late_init(struct omap2_hsmmc_info *controllers)
> +{
> + struct platform_device *pdev;
> + int res;
> +
> + for (; controllers->mmc; controllers++) {
> + if (!controllers->deferred)
> + continue;
> +
> + pdev = controllers->pdev;
> + if (!pdev)
> + continue;
> +
> + res = omap_device_register(pdev);
> + if (res) {
> + pr_err("Could not late init MMC %s\n",
> + controllers->name);
> + continue;
> + }
> + }
> +}
Most likely there's no need to pass struct omap2_hsmmc_info *controllers
to omap_hsmmc_late_init() here. And I'll also take a look at making
it a completion to make it more generic across various PMICs.
Tony
next prev parent reply other threads:[~2012-02-16 16:45 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:28 [PATCH 0/3] omap hsmmc init cleanup and section warning fixes for v3.4 merge window Tony Lindgren
2012-02-15 18:28 ` Tony Lindgren
2012-02-15 18:28 ` [PATCH 1/3] ARM: OMAP: omap_device: Expose omap_device_{alloc, delete, register} Tony Lindgren
2012-02-15 18:28 ` Tony Lindgren
2012-02-15 18:28 ` [PATCH 2/3] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins Tony Lindgren
2012-02-15 18:28 ` Tony Lindgren
2012-02-16 10:03 ` Rajendra Nayak
2012-02-16 10:03 ` Rajendra Nayak
2012-02-16 10:13 ` Rajendra Nayak
2012-02-16 10:13 ` Rajendra Nayak
2012-02-16 16:35 ` Tony Lindgren
2012-02-16 16:35 ` Tony Lindgren
2012-02-16 16:46 ` Cousson, Benoit
2012-02-16 16:46 ` Cousson, Benoit
2012-02-16 16:51 ` Rajendra Nayak
2012-02-16 16:51 ` Rajendra Nayak
2012-02-16 17:06 ` Tony Lindgren
2012-02-16 17:06 ` Tony Lindgren
2012-02-17 18:10 ` Tony Lindgren
2012-02-17 18:10 ` Tony Lindgren
2012-02-16 16:45 ` Tony Lindgren [this message]
2012-02-16 16:45 ` Tony Lindgren
2012-02-17 19:05 ` Tony Lindgren
2012-02-17 19:05 ` Tony Lindgren
2012-02-15 18:28 ` [PATCH 3/3] ARM: OMAP2+: Mark omap_hsmmc_init and omap_mux related functions as __init Tony Lindgren
2012-02-15 18:28 ` Tony Lindgren
2012-02-16 10:11 ` Russell King - ARM Linux
2012-02-16 10:11 ` Russell King - ARM Linux
2012-02-16 16:41 ` Tony Lindgren
2012-02-16 16:41 ` Tony Lindgren
2012-02-17 19:17 ` Tony Lindgren
2012-02-17 19:17 ` Tony Lindgren
2012-02-16 12:00 ` [PATCH 0/3] omap hsmmc init cleanup and section warning fixes for v3.4 merge window Nayak, Rajendra
2012-02-16 12:00 ` Nayak, Rajendra
2012-02-16 12:12 ` Russell King - ARM Linux
2012-02-16 12:12 ` Russell King - ARM Linux
2012-02-16 12:34 ` Rajendra Nayak
2012-02-16 12:34 ` Rajendra Nayak
2012-02-16 13:15 ` Rajendra Nayak
2012-02-16 13:15 ` Rajendra Nayak
2012-02-16 13:51 ` Russell King - ARM Linux
2012-02-16 13:51 ` Russell King - ARM Linux
2012-02-17 9:14 ` Russell King - ARM Linux
2012-02-17 9:14 ` Russell King - ARM Linux
2012-02-17 9:33 ` Rajendra Nayak
2012-02-17 9:33 ` Rajendra Nayak
2012-02-17 9:37 ` Rajendra Nayak
2012-02-17 9:37 ` Rajendra Nayak
2012-02-17 9:59 ` Rajendra Nayak
2012-02-17 9:59 ` Rajendra Nayak
2012-02-17 10:06 ` Russell King - ARM Linux
2012-02-17 10:06 ` Russell King - ARM Linux
2012-02-17 10:18 ` Rajendra Nayak
2012-02-17 10:18 ` Rajendra Nayak
2012-02-17 10:26 ` Rajendra Nayak
2012-02-17 10:26 ` Rajendra Nayak
2012-02-17 21:23 ` Tony Lindgren
2012-02-17 21:23 ` Tony Lindgren
2012-02-17 14:24 ` Rajendra Nayak
2012-02-17 14:24 ` Rajendra Nayak
2012-02-17 20:21 ` Tony Lindgren
2012-02-17 20:21 ` Tony Lindgren
2012-02-17 22:37 ` Tony Lindgren
2012-02-17 22:37 ` Tony Lindgren
2012-02-21 5:19 ` Rajendra Nayak
2012-02-21 5:19 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216164504.GD15692@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.