From: Andrea Arcangeli <aarcange@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-team@fedoraproject.org
Subject: Re: exit_mmap() BUG_ON triggering since 3.1
Date: Thu, 16 Feb 2012 22:42:45 +0100 [thread overview]
Message-ID: <20120216214245.GD23585@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1202160130500.16147@eggly.anvils>
On Thu, Feb 16, 2012 at 01:53:04AM -0800, Hugh Dickins wrote:
> Yes (and I think less troublesome than most BUGs, coming at exit
> while not holding locks; though we could well make it a WARN_ON,
> I don't think that existed back in the day).
A WARN_ON would be fine with me, go ahead if you prefer it... only
risk would be to go unnoticed or be underestimated. I am ok with the
BUG_ON too (even if this time it triggered false positives... sigh).
> Acked-by: Hugh Dickins <hughd@google.com>
Thanks for the quick review!
> In looking into the bug, it had actually bothered me a little that you
> were setting aside those pages, yet not counting them into nr_ptes;
> though the only thing that cares is oom_kill.c, and the count of pages
> in each hugepage can only dwarf the count in nr_ptes (whereas, without
> hugepages, it's possible to populate very sparsely and nr_ptes become
> significant).
Agreed, it's not significant either ways.
Running my two primary systems with this applied for half a day and no
problem so far so it should be good for -mm at least.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel-team@fedoraproject.org
Subject: Re: exit_mmap() BUG_ON triggering since 3.1
Date: Thu, 16 Feb 2012 22:42:45 +0100 [thread overview]
Message-ID: <20120216214245.GD23585@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1202160130500.16147@eggly.anvils>
On Thu, Feb 16, 2012 at 01:53:04AM -0800, Hugh Dickins wrote:
> Yes (and I think less troublesome than most BUGs, coming at exit
> while not holding locks; though we could well make it a WARN_ON,
> I don't think that existed back in the day).
A WARN_ON would be fine with me, go ahead if you prefer it... only
risk would be to go unnoticed or be underestimated. I am ok with the
BUG_ON too (even if this time it triggered false positives... sigh).
> Acked-by: Hugh Dickins <hughd@google.com>
Thanks for the quick review!
> In looking into the bug, it had actually bothered me a little that you
> were setting aside those pages, yet not counting them into nr_ptes;
> though the only thing that cares is oom_kill.c, and the count of pages
> in each hugepage can only dwarf the count in nr_ptes (whereas, without
> hugepages, it's possible to populate very sparsely and nr_ptes become
> significant).
Agreed, it's not significant either ways.
Running my two primary systems with this applied for half a day and no
problem so far so it should be good for -mm at least.
next prev parent reply other threads:[~2012-02-16 21:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:33 exit_mmap() BUG_ON triggering since 3.1 Dave Jones
2012-02-15 18:33 ` Dave Jones
2012-02-16 2:14 ` Hugh Dickins
2012-02-16 2:14 ` Hugh Dickins
2012-02-16 2:22 ` Roland Dreier
2012-02-16 2:22 ` Roland Dreier
2012-02-16 2:48 ` Hugh Dickins
2012-02-16 7:07 ` Andrea Arcangeli
2012-02-16 7:07 ` Andrea Arcangeli
2012-02-16 9:53 ` Hugh Dickins
2012-02-16 9:53 ` Hugh Dickins
2012-02-16 21:42 ` Andrea Arcangeli [this message]
2012-02-16 21:42 ` Andrea Arcangeli
2012-03-02 22:53 ` Hugh Dickins
2012-03-02 22:53 ` Hugh Dickins
2012-03-02 22:58 ` Andrew Morton
2012-03-02 22:58 ` Andrew Morton
2012-03-02 23:09 ` Hugh Dickins
2012-03-02 23:09 ` Hugh Dickins
2012-03-05 19:59 ` Josh Boyer
2012-03-05 19:59 ` Josh Boyer
2012-03-05 20:07 ` Andrew Morton
2012-03-05 20:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216214245.GD23585@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=hughd@google.com \
--cc=kernel-team@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.