From: Alexey Dobriyan <adobriyan@gmail.com>
To: David Windsor <dwindsor@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
pageexec@freemail.hu,
Ubuntu security discussion <ubuntu-hardened@lists.ubuntu.com>,
spender@grsecurity.net, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [ubuntu-hardened] Add overflow protection to kref
Date: Fri, 17 Feb 2012 09:33:19 +0300 [thread overview]
Message-ID: <20120217063318.GA3330@p183.telecom.by> (raw)
In-Reply-To: <CAEXv5_iRj6zHcKWtV0mgA4i_2u=TB1iQQMYFJAK4r6Ca=pimDA@mail.gmail.com>
On Thu, Feb 16, 2012 at 09:48:38PM -0500, David Windsor wrote:
> <snip>
>
> >>
> >> I have yet to see a patch, so why are we arguing about this? :)
> >>
> >> Again, I don't know of any kref overflows that have ever happened, so
> >> trying to "protect" this type of thing, seems odd to me.
> >
> > Well, I think the issue was to protect counting things (which seems to
> > be what PaX was after originally), and that kref seemed like the place
> > to put it. I'll let David take it further.
> >
>
> Patches are forthcoming that will first introduce overflow protection
> to kref.
Patches have already been posted:
http://marc.info/?l=linux-kernel&m=132337541830590&w=4
They were dropped for various (uninteresting) reasons, though.
> Once that's in place, I'll move a few refcount users from
> atomic_t to kref as a reference for other subsystems;
This sucks because dtor argument is mandatory.
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Dobriyan <adobriyan@gmail.com>
To: David Windsor <dwindsor@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
pageexec@freemail.hu,
Ubuntu security discussion <ubuntu-hardened@lists.ubuntu.com>,
spender@grsecurity.net, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [ubuntu-hardened] Add overflow protection to kref
Date: Fri, 17 Feb 2012 09:33:19 +0300 [thread overview]
Message-ID: <20120217063318.GA3330@p183.telecom.by> (raw)
In-Reply-To: <CAEXv5_iRj6zHcKWtV0mgA4i_2u=TB1iQQMYFJAK4r6Ca=pimDA@mail.gmail.com>
On Thu, Feb 16, 2012 at 09:48:38PM -0500, David Windsor wrote:
> <snip>
>
> >>
> >> I have yet to see a patch, so why are we arguing about this? :)
> >>
> >> Again, I don't know of any kref overflows that have ever happened, so
> >> trying to "protect" this type of thing, seems odd to me.
> >
> > Well, I think the issue was to protect counting things (which seems to
> > be what PaX was after originally), and that kref seemed like the place
> > to put it. I'll let David take it further.
> >
>
> Patches are forthcoming that will first introduce overflow protection
> to kref.
Patches have already been posted:
http://marc.info/?l=linux-kernel&m=132337541830590&w=4
They were dropped for various (uninteresting) reasons, though.
> Once that's in place, I'll move a few refcount users from
> atomic_t to kref as a reference for other subsystems;
This sucks because dtor argument is mandatory.
next prev parent reply other threads:[~2012-02-17 6:33 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 14:02 [kernel-hardening] Add overflow protection to kref David Windsor
2012-02-16 20:45 ` [kernel-hardening] " Kees Cook
2012-02-16 20:45 ` Kees Cook
2012-02-17 0:24 ` [kernel-hardening] " Greg Kroah-Hartman
2012-02-17 0:24 ` Greg Kroah-Hartman
2012-02-17 1:06 ` [kernel-hardening] " Kees Cook
2012-02-17 1:06 ` Kees Cook
2012-02-17 1:40 ` [kernel-hardening] " Greg KH
2012-02-17 1:40 ` Greg KH
2012-02-17 2:11 ` [kernel-hardening] Re: [ubuntu-hardened] " Kees Cook
2012-02-17 2:11 ` Kees Cook
2012-02-17 2:48 ` [kernel-hardening] " David Windsor
2012-02-17 2:48 ` David Windsor
2012-02-17 3:32 ` [kernel-hardening] " Greg KH
2012-02-17 3:32 ` Greg KH
2012-02-17 6:33 ` Alexey Dobriyan [this message]
2012-02-17 6:33 ` Alexey Dobriyan
2012-02-17 13:23 ` [kernel-hardening] " pageexec
2012-02-17 13:23 ` pageexec
2012-02-17 7:59 ` [kernel-hardening] " Vasiliy Kulikov
2012-02-17 7:59 ` Vasiliy Kulikov
2012-02-17 17:53 ` Greg KH
2012-02-17 17:54 ` Greg KH
2012-02-17 19:37 ` Vasiliy Kulikov
2012-02-17 23:39 ` Djalal Harouni
2012-02-18 1:44 ` Roland Dreier
2012-02-18 16:15 ` David Windsor
2012-02-18 16:35 ` Vasiliy Kulikov
2012-02-18 16:18 ` Greg KH
2012-02-24 17:58 ` David Windsor
2012-02-24 18:37 ` Greg KH
2012-02-24 18:52 ` Kees Cook
2012-02-24 19:05 ` Nick Bowler
2012-02-24 19:13 ` Vasiliy Kulikov
2012-02-24 19:35 ` Nick Bowler
2012-02-24 21:59 ` PaX Team
2012-02-24 18:58 ` Vasiliy Kulikov
2012-02-24 19:41 ` Greg KH
2012-02-24 20:04 ` Kees Cook
2012-02-24 19:04 ` David Windsor
2012-02-24 22:14 ` PaX Team
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217063318.GA3330@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=dwindsor@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pageexec@freemail.hu \
--cc=spender@grsecurity.net \
--cc=ubuntu-hardened@lists.ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.