* [PATCH 1/3] regulator: fix wrong header name in description
@ 2012-02-17 6:41 Kim, Milo
2012-02-17 7:10 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Kim, Milo @ 2012-02-17 6:41 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel@vger.kernel.org
The 'mode' is defined in consumer.h.
* patch base version : linux-3.2.4
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
include/linux/regulator/driver.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h
index 52c89ae..df6e9ec 100644
--- a/include/linux/regulator/driver.h
+++ b/include/linux/regulator/driver.h
@@ -104,7 +104,7 @@ struct regulator_ops {
int (*disable) (struct regulator_dev *);
int (*is_enabled) (struct regulator_dev *);
- /* get/set regulator operating mode (defined in regulator.h) */
+ /* get/set regulator operating mode (defined in consumer.h) */
int (*set_mode) (struct regulator_dev *, unsigned int mode);
unsigned int (*get_mode) (struct regulator_dev *);
@@ -135,7 +135,7 @@ struct regulator_ops {
int (*set_suspend_enable) (struct regulator_dev *);
int (*set_suspend_disable) (struct regulator_dev *);
- /* set regulator suspend operating mode (defined in regulator.h) */
+ /* set regulator suspend operating mode (defined in consumer.h) */
int (*set_suspend_mode) (struct regulator_dev *, unsigned int mode);
};
--
1.7.4.1
Best Regards,
Milo (Woogyom) Kim
Texas Instruments Incorporated
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/3] regulator: fix wrong header name in description
2012-02-17 6:41 [PATCH 1/3] regulator: fix wrong header name in description Kim, Milo
@ 2012-02-17 7:10 ` Mark Brown
2012-02-17 7:17 ` Kim, Milo
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-02-17 7:10 UTC (permalink / raw)
To: Kim, Milo; +Cc: linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Thu, Feb 16, 2012 at 10:41:32PM -0800, Kim, Milo wrote:
> The 'mode' is defined in consumer.h.
>
> * patch base version : linux-3.2.4
Applied, thanks, but you should only include administrative stuff like
the above after the ---. You should also always submit patches against
either Linus' tree (for fixes) or -next (for everything else) rather
than an old kernel.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/3] regulator: fix wrong header name in description
2012-02-17 7:10 ` Mark Brown
@ 2012-02-17 7:17 ` Kim, Milo
0 siblings, 0 replies; 3+ messages in thread
From: Kim, Milo @ 2012-02-17 7:17 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel@vger.kernel.org
OK, thanks for your advice.
Then should I resend other two patches based on linux-next tree ?
Milo -
> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Friday, February 17, 2012 4:10 PM
> To: Kim, Milo
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] regulator: fix wrong header name in
> description
>
> On Thu, Feb 16, 2012 at 10:41:32PM -0800, Kim, Milo wrote:
> > The 'mode' is defined in consumer.h.
> >
> > * patch base version : linux-3.2.4
>
> Applied, thanks, but you should only include administrative stuff like
> the above after the ---. You should also always submit patches against
> either Linus' tree (for fixes) or -next (for everything else) rather
> than an old kernel.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-17 7:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-17 6:41 [PATCH 1/3] regulator: fix wrong header name in description Kim, Milo
2012-02-17 7:10 ` Mark Brown
2012-02-17 7:17 ` Kim, Milo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.