All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Rik van Riel <riel@redhat.com>,
	Federica Teodori <federica.teodori@googlemail.com>,
	Lucian Adrian Grijincu <lucian.grijincu@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Eric Paris <eparis@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH v2012.2] fs: symlink restrictions on sticky directories
Date: Fri, 17 Feb 2012 15:42:13 -0800	[thread overview]
Message-ID: <20120217154213.ecf4f7b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jJ629rrEuQX1MSiqM2SvhCSmZYuNZdOA4zBr5GZHtFcuw@mail.gmail.com>

On Fri, 17 Feb 2012 15:36:09 -0800
Kees Cook <keescook@chromium.org> wrote:

> > I think I disagree with this. __If the person compiling the kernel
> > includes the feature in his kernel via the time-honoured process of
> > "wtf is that thing? __Yeah, whatev", it gets turned on by default. __This
> > could easily result in weird failures which would take a *long* time
> > for an unsuspecting person to debug.
> >
> > Would it not be kinder to our users to start this out as
> > turned-off-at-runtime unless the kernel configurer has deliberately
> > gone in and enabled it?
> 
> There was a fair bit of back-and-forth discussion about it.
> Originally, I had it disabled, but, IIRC, Ingo urged me to have it be
> the default. I can sent a patch to disable it if you want.

What is the reasoning behind the current setting?

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Rik van Riel <riel@redhat.com>,
	Federica Teodori <federica.teodori@googlemail.com>,
	Lucian Adrian Grijincu <lucian.grijincu@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Eric Paris <eparis@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2012.2] fs: symlink restrictions on sticky directories
Date: Fri, 17 Feb 2012 15:42:13 -0800	[thread overview]
Message-ID: <20120217154213.ecf4f7b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jJ629rrEuQX1MSiqM2SvhCSmZYuNZdOA4zBr5GZHtFcuw@mail.gmail.com>

On Fri, 17 Feb 2012 15:36:09 -0800
Kees Cook <keescook@chromium.org> wrote:

> > I think I disagree with this. __If the person compiling the kernel
> > includes the feature in his kernel via the time-honoured process of
> > "wtf is that thing? __Yeah, whatev", it gets turned on by default. __This
> > could easily result in weird failures which would take a *long* time
> > for an unsuspecting person to debug.
> >
> > Would it not be kinder to our users to start this out as
> > turned-off-at-runtime unless the kernel configurer has deliberately
> > gone in and enabled it?
> 
> There was a fair bit of back-and-forth discussion about it.
> Originally, I had it disabled, but, IIRC, Ingo urged me to have it be
> the default. I can sent a patch to disable it if you want.

What is the reasoning behind the current setting?

  reply	other threads:[~2012-02-17 23:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 18:55 [kernel-hardening] [PATCH v2012.2] fs: symlink restrictions on sticky directories Kees Cook
2012-01-07 18:55 ` Kees Cook
2012-01-08 11:44 ` [kernel-hardening] " Matthew Wilcox
2012-01-08 11:44   ` Matthew Wilcox
2012-01-08 17:53   ` [kernel-hardening] " Kees Cook
2012-01-08 17:53     ` Kees Cook
2012-01-08 17:53     ` Kees Cook
2012-02-17 23:24 ` [kernel-hardening] " Andrew Morton
2012-02-17 23:24   ` Andrew Morton
2012-02-17 23:36   ` [kernel-hardening] " Kees Cook
2012-02-17 23:36     ` Kees Cook
2012-02-17 23:42     ` Andrew Morton [this message]
2012-02-17 23:42       ` Andrew Morton
2012-02-18  1:09       ` [kernel-hardening] " Kees Cook
2012-02-18  1:09         ` Kees Cook
2012-02-19 12:31         ` [kernel-hardening] " Ingo Molnar
2012-02-19 12:31           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120217154213.ecf4f7b4.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=drosenberg@vsecurity.com \
    --cc=eparis@redhat.com \
    --cc=federica.teodori@googlemail.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucian.grijincu@gmail.com \
    --cc=mingo@elte.hu \
    --cc=rdunlap@xenotime.net \
    --cc=riel@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.