From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
Takashi Iwai <tiwai@suse.de>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ALSA: Remove __devinit annotation for pxa2xx_ac97_hw_probe to fix section mismatch warning
Date: Sun, 19 Feb 2012 18:20:08 +0000 [thread overview]
Message-ID: <20120219182005.GA16078@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1329637158.4818.4.camel@phoenix>
On Sun, Feb 19, 2012 at 03:39:18PM +0800, Axel Lin wrote:
> This fixes below build warning:
> WARNING: vmlinux.o(.text+0x1e632c): Section mismatch in reference from the function pxa2xx_ac97_probe() to the function .devinit.text:pxa2xx_ac97_hw_probe()
> The function pxa2xx_ac97_probe() references
> the function __devinit pxa2xx_ac97_hw_probe().
> This is often because pxa2xx_ac97_probe lacks a __devinit
> annotation or the annotation of pxa2xx_ac97_hw_probe is wrong.
This seems like the wrong fix - shouldn't we be adding annotations
rather than removing them here?
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ALSA: Remove __devinit annotation for pxa2xx_ac97_hw_probe to fix section mismatch warning
Date: Sun, 19 Feb 2012 18:20:08 +0000 [thread overview]
Message-ID: <20120219182005.GA16078@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1329637158.4818.4.camel@phoenix>
On Sun, Feb 19, 2012 at 03:39:18PM +0800, Axel Lin wrote:
> This fixes below build warning:
> WARNING: vmlinux.o(.text+0x1e632c): Section mismatch in reference from the function pxa2xx_ac97_probe() to the function .devinit.text:pxa2xx_ac97_hw_probe()
> The function pxa2xx_ac97_probe() references
> the function __devinit pxa2xx_ac97_hw_probe().
> This is often because pxa2xx_ac97_probe lacks a __devinit
> annotation or the annotation of pxa2xx_ac97_hw_probe is wrong.
This seems like the wrong fix - shouldn't we be adding annotations
rather than removing them here?
next prev parent reply other threads:[~2012-02-19 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 7:39 [PATCH 1/2] ALSA: Remove __devinit annotation for pxa2xx_ac97_hw_probe to fix section mismatch warning Axel Lin
2012-02-19 7:39 ` Axel Lin
2012-02-19 7:40 ` [PATCH 2/2] ALSA: pxa2xx-pcm: replace 0xffffffff with DMA_BIT_MASK macro Axel Lin
2012-02-19 7:40 ` Axel Lin
2012-02-19 18:20 ` Mark Brown [this message]
2012-02-19 18:20 ` [PATCH 1/2] ALSA: Remove __devinit annotation for pxa2xx_ac97_hw_probe to fix section mismatch warning Mark Brown
2012-02-20 0:03 ` Axel Lin
2012-02-20 0:03 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120219182005.GA16078@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.