From: Andrea Arcangeli <aarcange@redhat.com>
To: Dean Nelson <dnelson@redhat.com>
Cc: linux-mm@kvack.org,
Jin Dongming <jin.dongming@np.css.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thp: allow a hwpoisoned head page to be put back to LRU
Date: Mon, 20 Feb 2012 22:29:55 +0100 [thread overview]
Message-ID: <20120220212955.GD10222@redhat.com> (raw)
In-Reply-To: <20120220211040.8887.22420.email-sent-by-dnelson@aqua>
On Mon, Feb 20, 2012 at 04:10:40PM -0500, Dean Nelson wrote:
> Andrea Arcangeli pointed out to me that a check in __memory_failure() which
> was intended to prevent THP tail pages from being checked for the absence
> of the PG_lru flag (something that is always the case), was also preventing
> THP head pages from being checked.
>
> A THP head page could actually benefit from the call to shake_page() by
> ending up being put back to a LRU, provided it had been waiting in a
> pagevec array.
>
> Andrea suggested that the "!PageTransCompound(p)" in the if-statement
> should be replaced by a "!PageTransTail(p)", thus allowing THP head pages
> to be checked and possibly shaken.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Dean Nelson <dnelson@redhat.com>
Cc: linux-mm@kvack.org,
Jin Dongming <jin.dongming@np.css.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thp: allow a hwpoisoned head page to be put back to LRU
Date: Mon, 20 Feb 2012 22:29:55 +0100 [thread overview]
Message-ID: <20120220212955.GD10222@redhat.com> (raw)
In-Reply-To: <20120220211040.8887.22420.email-sent-by-dnelson@aqua>
On Mon, Feb 20, 2012 at 04:10:40PM -0500, Dean Nelson wrote:
> Andrea Arcangeli pointed out to me that a check in __memory_failure() which
> was intended to prevent THP tail pages from being checked for the absence
> of the PG_lru flag (something that is always the case), was also preventing
> THP head pages from being checked.
>
> A THP head page could actually benefit from the call to shake_page() by
> ending up being put back to a LRU, provided it had been waiting in a
> pagevec array.
>
> Andrea suggested that the "!PageTransCompound(p)" in the if-statement
> should be replaced by a "!PageTransTail(p)", thus allowing THP head pages
> to be checked and possibly shaken.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
next prev parent reply other threads:[~2012-02-20 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 21:10 [PATCH] thp: allow a hwpoisoned head page to be put back to LRU Dean Nelson
2012-02-20 21:10 ` Dean Nelson
2012-02-20 21:29 ` Andrea Arcangeli [this message]
2012-02-20 21:29 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220212955.GD10222@redhat.com \
--to=aarcange@redhat.com \
--cc=dnelson@redhat.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.