All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT_MASK().
Date: Tue, 21 Feb 2012 13:01:03 +0000	[thread overview]
Message-ID: <20120221140103.773d0962@stein> (raw)
In-Reply-To: <1329818893-8276-1-git-send-email-santoshprasadnayak@gmail.com>

On Feb 21 santosh nayak wrote:
> Use the macro DMA_BIT_MASK instead of the constant  0xffffffff
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
>  drivers/firewire/nosy.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
> index 763626b..a7c4422 100644
> --- a/drivers/firewire/nosy.c
> +++ b/drivers/firewire/nosy.c
> @@ -36,7 +36,7 @@
>  #include <linux/timex.h>
>  #include <linux/uaccess.h>
>  #include <linux/wait.h>
> -
> +#include <linux/dma-mapping.h>
>  #include <linux/atomic.h>
>  #include <asm/byteorder.h>
>  
> @@ -536,7 +536,7 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused)
>  	u32 p, end;
>  	int ret, i;
>  
> -	if (pci_set_dma_mask(dev, 0xffffffff)) {
> +	if (pci_set_dma_mask(dev, DMA_BIT_MASK(32))) {
>  		dev_err(&dev->dev,
>  		    "DMA address limits not supported for PCILynx hardware\n");
>  		return -ENXIO;

Thanks, I will commit it to linux1394.git soon.
-- 
Stefan Richter
-===-==-- --=- =-=-http://arcgraph.de/sr/

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT_MASK().
Date: Tue, 21 Feb 2012 14:01:03 +0100	[thread overview]
Message-ID: <20120221140103.773d0962@stein> (raw)
In-Reply-To: <1329818893-8276-1-git-send-email-santoshprasadnayak@gmail.com>

On Feb 21 santosh nayak wrote:
> Use the macro DMA_BIT_MASK instead of the constant  0xffffffff
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
>  drivers/firewire/nosy.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
> index 763626b..a7c4422 100644
> --- a/drivers/firewire/nosy.c
> +++ b/drivers/firewire/nosy.c
> @@ -36,7 +36,7 @@
>  #include <linux/timex.h>
>  #include <linux/uaccess.h>
>  #include <linux/wait.h>
> -
> +#include <linux/dma-mapping.h>
>  #include <linux/atomic.h>
>  #include <asm/byteorder.h>
>  
> @@ -536,7 +536,7 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused)
>  	u32 p, end;
>  	int ret, i;
>  
> -	if (pci_set_dma_mask(dev, 0xffffffff)) {
> +	if (pci_set_dma_mask(dev, DMA_BIT_MASK(32))) {
>  		dev_err(&dev->dev,
>  		    "DMA address limits not supported for PCILynx hardware\n");
>  		return -ENXIO;

Thanks, I will commit it to linux1394.git soon.
-- 
Stefan Richter
-=====-===-- --=- =-=-=
http://arcgraph.de/sr/

  reply	other threads:[~2012-02-21 13:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21 10:08 [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT_MASK() santosh nayak
2012-02-21 10:20 ` santosh nayak
2012-02-21 13:01 ` Stefan Richter [this message]
2012-02-21 13:01   ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120221140103.773d0962@stein \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=santoshprasadnayak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.