From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Justin T. Gibbs" <justing@spectralogic.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 1 of 4 v3] blkif.h: Miscelaneous style fixes
Date: Tue, 21 Feb 2012 09:10:52 -0500 [thread overview]
Message-ID: <20120221141052.GD11950@phenom.dumpdata.com> (raw)
In-Reply-To: <28137a4e39a3ed61511f.1329761242@ns1.eng.sldomain.com>
On Mon, Feb 20, 2012 at 11:07:22AM -0700, Justin T. Gibbs wrote:
> o Remove trailing whitespace.
> o Remove a blank line so that a comment block is adjacent to the
> code it documents.
>
> No functional changes.
>
> Signed-off-by: Justin T. Gibbs <justing@spectralogic.com>
OK, looks good.
>
> diff -r 87218bd367be -r 28137a4e39a3 xen/include/public/io/blkif.h
> --- a/xen/include/public/io/blkif.h Fri Feb 17 12:24:38 2012 +0000
> +++ b/xen/include/public/io/blkif.h Mon Feb 20 10:48:09 2012 -0700
> @@ -1,8 +1,8 @@
> /******************************************************************************
> * blkif.h
> - *
> + *
> * Unified block-device I/O interface for Xen guest OSes.
> - *
> + *
> * Permission is hereby granted, free of charge, to any person obtaining a copy
> * of this software and associated documentation files (the "Software"), to
> * deal in the Software without restriction, including without limitation the
> @@ -35,7 +35,7 @@
> * notification can be made conditional on req_event (i.e., the generic
> * hold-off mechanism provided by the ring macros). Backends must set
> * req_event appropriately (e.g., using RING_FINAL_CHECK_FOR_REQUESTS()).
> - *
> + *
> * Back->front notifications: When enqueuing a new response, sending a
> * notification can be made conditional on rsp_event (i.e., the generic
> * hold-off mechanism provided by the ring macros). Frontends must set
> @@ -133,7 +133,7 @@
> */
> #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11
>
> -/*
> +/*
> * NB. first_sect and last_sect in blkif_request_segment, as well as
> * sector_number in blkif_request, are always expressed in 512-byte units.
> * However they must be properly aligned to the real sector size of the
> @@ -192,7 +192,6 @@ typedef struct blkif_response blkif_resp
> /*
> * Generate blkif ring structures and types.
> */
> -
> DEFINE_RING_TYPES(blkif, struct blkif_request, struct blkif_response);
>
> #define VDISK_CDROM 0x1
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2012-02-21 14:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 18:07 [PATCH 0 of 4 v3] blkif.h: Document protocol and existing extensions Justin T. Gibbs
2012-02-20 18:07 ` [PATCH 1 of 4 v3] blkif.h: Miscelaneous style fixes Justin T. Gibbs
2012-02-21 14:10 ` Konrad Rzeszutek Wilk [this message]
2012-02-21 14:15 ` Ian Campbell
2012-02-20 18:07 ` [PATCH 2 of 4 v3] blkif.h: Provide more complete documentation of the blkif interface Justin T. Gibbs
2012-02-21 14:10 ` Konrad Rzeszutek Wilk
2012-02-21 20:59 ` Justin T. Gibbs
2012-02-21 21:36 ` Konrad Rzeszutek Wilk
2012-02-22 11:14 ` Ian Campbell
2012-02-23 18:50 ` Konrad Rzeszutek Wilk
2012-02-23 22:41 ` Justin T. Gibbs
2012-02-21 14:27 ` Ian Campbell
2012-02-21 18:14 ` Justin T. Gibbs
2012-02-21 19:41 ` Ian Campbell
2012-02-20 18:07 ` [PATCH 3 of 4 v3] blkif.h: Document the RedHat and Citrix blkif multi-page ring extensions Justin T. Gibbs
2012-02-21 14:12 ` Konrad Rzeszutek Wilk
2012-02-21 14:32 ` Ian Campbell
2012-02-20 18:07 ` [PATCH 4 of 4 v3] blkif.h: Define and document the request number/size/segments extension Justin T. Gibbs
2012-02-21 14:22 ` Konrad Rzeszutek Wilk
2012-02-21 18:11 ` Justin T. Gibbs
2012-02-21 14:38 ` Ian Campbell
2012-02-21 18:03 ` Justin T. Gibbs
2012-02-21 19:42 ` Ian Campbell
2012-02-21 14:02 ` [PATCH 0 of 4 v3] blkif.h: Document protocol and existing extensions Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221141052.GD11950@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=justing@spectralogic.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.