From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] svcrdma: silence a Sparse warning
Date: Tue, 21 Feb 2012 21:23:23 +0000 [thread overview]
Message-ID: <20120221212323.GA4426@fieldses.org> (raw)
In-Reply-To: <4F4407E1.7030400@opengridcomputing.com>
On Tue, Feb 21, 2012 at 03:08:49PM -0600, Tom Tucker wrote:
>
> This is my bad. I don't know why my sparse didn't catch it, it seems
> like it should have. Thanks for
> fixing it Dan.
Thanks, applying.--b.
>
> Tom
>
>
> On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> >(Cc'ing Tom).
> >
> >On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> >>Sparse complains that the definition function definition and the
> >>implementation aren't anotated the same way.
> >>
> >>Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> >>
> >>diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> >>index d205e9f..0b8e3e6 100644
> >>--- a/include/linux/sunrpc/svc_rdma.h
> >>+++ b/include/linux/sunrpc/svc_rdma.h
> >>@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> >> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> >> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> >> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> >>- u32, u64, u32);
> >>+ __be32, __be64, u32);
> >> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> >> struct rpcrdma_msg *,
> >> struct rpcrdma_msg *,
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] svcrdma: silence a Sparse warning
Date: Tue, 21 Feb 2012 16:23:23 -0500 [thread overview]
Message-ID: <20120221212323.GA4426@fieldses.org> (raw)
In-Reply-To: <4F4407E1.7030400@opengridcomputing.com>
On Tue, Feb 21, 2012 at 03:08:49PM -0600, Tom Tucker wrote:
>
> This is my bad. I don't know why my sparse didn't catch it, it seems
> like it should have. Thanks for
> fixing it Dan.
Thanks, applying.--b.
>
> Tom
>
>
> On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> >(Cc'ing Tom).
> >
> >On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> >>Sparse complains that the definition function definition and the
> >>implementation aren't anotated the same way.
> >>
> >>Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> >>
> >>diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> >>index d205e9f..0b8e3e6 100644
> >>--- a/include/linux/sunrpc/svc_rdma.h
> >>+++ b/include/linux/sunrpc/svc_rdma.h
> >>@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> >> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> >> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> >> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> >>- u32, u64, u32);
> >>+ __be32, __be64, u32);
> >> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> >> struct rpcrdma_msg *,
> >> struct rpcrdma_msg *,
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-21 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 7:28 [patch] svcrdma: silence a Sparse warning Dan Carpenter
2012-02-21 7:28 ` Dan Carpenter
2012-02-21 21:06 ` J. Bruce Fields
2012-02-21 21:06 ` J. Bruce Fields
2012-02-21 21:08 ` Tom Tucker
2012-02-21 21:08 ` Tom Tucker
2012-02-21 21:23 ` J. Bruce Fields [this message]
2012-02-21 21:23 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221212323.GA4426@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.