From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Brown <davidb@davidb.org>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch v2] Btrfs: silence a compiler warning
Date: Wed, 22 Feb 2012 19:41:57 +0000 [thread overview]
Message-ID: <20120222194157.GA4045@mwanda> (raw)
In-Reply-To: <20120222162926.GA25392@davidb.org>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
Gcc warns that "ret" can be used uninitialized. It can't actually be
used uninitialized because btrfs_num_copies() always returns 1 or more.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: use the uninitialized_var() macro instead of initializing to 0.
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
index 064b29b..3bb3853 100644
--- a/fs/btrfs/check-integrity.c
+++ b/fs/btrfs/check-integrity.c
@@ -643,7 +643,7 @@ static struct btrfsic_dev_state *btrfsic_dev_state_hashtable_lookup(
static int btrfsic_process_superblock(struct btrfsic_state *state,
struct btrfs_fs_devices *fs_devices)
{
- int ret;
+ int uninitialized_var(ret);
struct btrfs_super_block *selected_super;
struct list_head *dev_head = &fs_devices->devices;
struct btrfs_device *device;
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Brown <davidb@davidb.org>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch v2] Btrfs: silence a compiler warning
Date: Wed, 22 Feb 2012 22:41:57 +0300 [thread overview]
Message-ID: <20120222194157.GA4045@mwanda> (raw)
In-Reply-To: <20120222162926.GA25392@davidb.org>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
Gcc warns that "ret" can be used uninitialized. It can't actually be
used uninitialized because btrfs_num_copies() always returns 1 or more.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: use the uninitialized_var() macro instead of initializing to 0.
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
index 064b29b..3bb3853 100644
--- a/fs/btrfs/check-integrity.c
+++ b/fs/btrfs/check-integrity.c
@@ -643,7 +643,7 @@ static struct btrfsic_dev_state *btrfsic_dev_state_hashtable_lookup(
static int btrfsic_process_superblock(struct btrfsic_state *state,
struct btrfs_fs_devices *fs_devices)
{
- int ret;
+ int uninitialized_var(ret);
struct btrfs_super_block *selected_super;
struct list_head *dev_head = &fs_devices->devices;
struct btrfs_device *device;
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-22 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 7:30 [patch] Btrfs: silence a compiler warning Dan Carpenter
2012-02-22 7:30 ` Dan Carpenter
2012-02-22 16:29 ` David Brown
2012-02-22 16:29 ` David Brown
2012-02-22 16:37 ` Dan Carpenter
2012-02-22 16:37 ` Dan Carpenter
2012-02-22 19:41 ` Dan Carpenter [this message]
2012-02-22 19:41 ` [patch v2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222194157.GA4045@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.mason@oracle.com \
--cc=davidb@davidb.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.