From: Pavel Roskin <proski@gnu.org>
To: wharms@bfs.de
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Jouni Malinen <jouni.malinen@atheros.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: wlan-ng: memsetting the wrong amount of data
Date: Thu, 23 Feb 2012 22:55:21 +0000 [thread overview]
Message-ID: <20120223175521.64aec938@mj> (raw)
In-Reply-To: <4F44A279.7010403@bfs.de>
On Wed, 22 Feb 2012 09:08:25 +0100
walter harms <wharms@bfs.de> wrote:
> Am 22.02.2012 08:54, schrieb Dan Carpenter:
> > On Tue, Feb 21, 2012 at 05:39:42PM +0100, walter harms wrote:
> >>> - memset(&(msg1.bssid.data), 0xFF,
> >>> sizeof(p80211item_pstr6_t));
> >>> + memset(&msg1.bssid.data, 0xFF, sizeof(msg1.bssid.data));
> >>> msg1.bssid.data.len = 6;
> >>
> >> maybe msg1.bssid.data.len is related to msg1.bssid.data ?
> >> I guess sizeof(msg1.bssid.data)-1 (why -1).
> >>
> >> perhaps you can fix both ?
> >>
> >
> > It's an interesting point. The problem is that I don't actually
> > have this hardware. On the patch which I sent, it was obvious what
> > the intent. My guess is that msg1.bssid.data[] should have 6
> > elements instead of 7, but I don't feel confident enough to sign off
> > on that.
msg1.bssid.data.data has 6 elements. msg1.bssid.data is a Pascal
string, i.e. a length byte and 6 bytes of data.
The intention of the code must have been:
memset(&msg1.bssid.data.data, 0xFF, sizeof(msg1.bssid.data.data));
sizeof(msg1.bssid.data.data) is 6.
Writing 15 bytes to a structure that is 7 bytes long is certainly
wrong and should be fixed.
I have the hardware, so please copy me if testing is needed.
--
Regards,
Pavel Roskin
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Roskin <proski@gnu.org>
To: wharms@bfs.de
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Jouni Malinen <jouni.malinen@atheros.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: wlan-ng: memsetting the wrong amount of data
Date: Thu, 23 Feb 2012 17:55:21 -0500 [thread overview]
Message-ID: <20120223175521.64aec938@mj> (raw)
In-Reply-To: <4F44A279.7010403@bfs.de>
On Wed, 22 Feb 2012 09:08:25 +0100
walter harms <wharms@bfs.de> wrote:
> Am 22.02.2012 08:54, schrieb Dan Carpenter:
> > On Tue, Feb 21, 2012 at 05:39:42PM +0100, walter harms wrote:
> >>> - memset(&(msg1.bssid.data), 0xFF,
> >>> sizeof(p80211item_pstr6_t));
> >>> + memset(&msg1.bssid.data, 0xFF, sizeof(msg1.bssid.data));
> >>> msg1.bssid.data.len = 6;
> >>
> >> maybe msg1.bssid.data.len is related to msg1.bssid.data ?
> >> I guess sizeof(msg1.bssid.data)-1 (why -1).
> >>
> >> perhaps you can fix both ?
> >>
> >
> > It's an interesting point. The problem is that I don't actually
> > have this hardware. On the patch which I sent, it was obvious what
> > the intent. My guess is that msg1.bssid.data[] should have 6
> > elements instead of 7, but I don't feel confident enough to sign off
> > on that.
msg1.bssid.data.data has 6 elements. msg1.bssid.data is a Pascal
string, i.e. a length byte and 6 bytes of data.
The intention of the code must have been:
memset(&msg1.bssid.data.data, 0xFF, sizeof(msg1.bssid.data.data));
sizeof(msg1.bssid.data.data) is 6.
Writing 15 bytes to a structure that is 7 bytes long is certainly
wrong and should be fixed.
I have the hardware, so please copy me if testing is needed.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2012-02-23 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 14:18 [patch] Staging: wlan-ng: memsetting the wrong amount of data Dan Carpenter
2012-02-21 16:39 ` walter harms
2012-02-22 7:54 ` Dan Carpenter
2012-02-22 7:54 ` Dan Carpenter
2012-02-22 8:08 ` walter harms
2012-02-22 8:08 ` walter harms
2012-02-23 22:55 ` Pavel Roskin [this message]
2012-02-23 22:55 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223175521.64aec938@mj \
--to=proski@gnu.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=jouni.malinen@atheros.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.