From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lrg@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators
Date: Fri, 24 Feb 2012 14:50:27 +0000 [thread overview]
Message-ID: <20120224145027.GN5450@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1330094532.4102.555.camel@sokoban>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Fri, Feb 24, 2012 at 04:42:12PM +0200, Tero Kristo wrote:
> On Fri, 2012-02-24 at 14:34 +0000, Mark Brown wrote:
> > Ah, so it is - we're fixing things up in the core. I'd forgotten we did
> > that.
> So, no need to add list_voltage to this, I just fix the return values
> for the get / set and send the new version, am I right?
I guess. Though actually given that there's no interaction with the
chip itself at all I'm not sure I understand why this is part of the
twl6030 driver rather than being a separate driver for whatever
implements the operations - it's not like the case with the other
regulators where there was some functionality implemented through the
twl6030 driver beyond straight passthrough.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators
Date: Fri, 24 Feb 2012 14:50:27 +0000 [thread overview]
Message-ID: <20120224145027.GN5450@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1330094532.4102.555.camel@sokoban>
On Fri, Feb 24, 2012 at 04:42:12PM +0200, Tero Kristo wrote:
> On Fri, 2012-02-24 at 14:34 +0000, Mark Brown wrote:
> > Ah, so it is - we're fixing things up in the core. I'd forgotten we did
> > that.
> So, no need to add list_voltage to this, I just fix the return values
> for the get / set and send the new version, am I right?
I guess. Though actually given that there's no interaction with the
chip itself at all I'm not sure I understand why this is part of the
twl6030 driver rather than being a separate driver for whatever
implements the operations - it's not like the case with the other
regulators where there was some functionality implemented through the
twl6030 driver beyond straight passthrough.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120224/5ffa8938/attachment.sig>
next prev parent reply other threads:[~2012-02-24 14:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 11:05 [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators Tero Kristo
2012-02-23 11:05 ` Tero Kristo
2012-02-23 15:34 ` Mark Brown
2012-02-23 15:34 ` Mark Brown
2012-02-24 9:38 ` Tero Kristo
2012-02-24 9:38 ` Tero Kristo
2012-02-24 11:49 ` Mark Brown
2012-02-24 11:49 ` Mark Brown
2012-02-24 13:16 ` Tero Kristo
2012-02-24 13:16 ` Tero Kristo
2012-02-24 13:24 ` Mark Brown
2012-02-24 13:24 ` Mark Brown
2012-02-24 13:56 ` Tero Kristo
2012-02-24 13:56 ` Tero Kristo
2012-02-24 14:01 ` Mark Brown
2012-02-24 14:01 ` Mark Brown
2012-02-24 14:25 ` Tero Kristo
2012-02-24 14:25 ` Tero Kristo
2012-02-24 14:34 ` Mark Brown
2012-02-24 14:34 ` Mark Brown
2012-02-24 14:42 ` Tero Kristo
2012-02-24 14:42 ` Tero Kristo
2012-02-24 14:50 ` Mark Brown [this message]
2012-02-24 14:50 ` Mark Brown
2012-02-24 15:04 ` Tero Kristo
2012-02-24 15:04 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224145027.GN5450@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.