All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	santosh nayak <santoshprasadnayak@gmail.com>
Cc: xfs-masters@oss.sgi.com, elder@kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Use memset to initialize structure member.
Date: Fri, 24 Feb 2012 16:05:05 +0000	[thread overview]
Message-ID: <20120224160505.GF7762@sgi.com> (raw)
In-Reply-To: <20120224075354.GA3649@mwanda>

Santosh,

On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
> On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@gmail.com>
> > 
> > Sparse is giving following warning:
> > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
> > 
> 
> You could just do:
> 	struct xfs_bmalloca     bma = {};

This aggregate initializer seems cleaner than memset.  Do you
mind resending the patch with Dan's suggestion?                                 
                                                                                
Thanks for your contribution.  ;)    

-Ben

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	santosh nayak <santoshprasadnayak@gmail.com>
Cc: xfs-masters@oss.sgi.com, elder@kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Use memset to initialize structure member.
Date: Fri, 24 Feb 2012 10:05:05 -0600	[thread overview]
Message-ID: <20120224160505.GF7762@sgi.com> (raw)
In-Reply-To: <20120224075354.GA3649@mwanda>

Santosh,

On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
> On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@gmail.com>
> > 
> > Sparse is giving following warning:
> > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
> > 
> 
> You could just do:
> 	struct xfs_bmalloca     bma = {};

This aggregate initializer seems cleaner than memset.  Do you
mind resending the patch with Dan's suggestion?                                 
                                                                                
Thanks for your contribution.  ;)    

-Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	santosh nayak <santoshprasadnayak@gmail.com>
Cc: elder@kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	xfs-masters@oss.sgi.com
Subject: Re: [PATCH] xfs: Use memset to initialize structure member.
Date: Fri, 24 Feb 2012 10:05:05 -0600	[thread overview]
Message-ID: <20120224160505.GF7762@sgi.com> (raw)
In-Reply-To: <20120224075354.GA3649@mwanda>

Santosh,

On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
> On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@gmail.com>
> > 
> > Sparse is giving following warning:
> > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
> > 
> 
> You could just do:
> 	struct xfs_bmalloca     bma = {};

This aggregate initializer seems cleaner than memset.  Do you
mind resending the patch with Dan's suggestion?                                 
                                                                                
Thanks for your contribution.  ;)    

-Ben

  reply	other threads:[~2012-02-24 16:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24  7:08 [PATCH] xfs: Use memset to initialize structure member santosh nayak
2012-02-24  7:20 ` santosh nayak
2012-02-24  7:08 ` santosh nayak
2012-02-24  7:53 ` Dan Carpenter
2012-02-24  7:53   ` Dan Carpenter
2012-02-24  7:53   ` Dan Carpenter
2012-02-24 16:05   ` Ben Myers [this message]
2012-02-24 16:05     ` Ben Myers
2012-02-24 16:05     ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120224160505.GF7762@sgi.com \
    --to=bpm@sgi.com \
    --cc=dan.carpenter@oracle.com \
    --cc=elder@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=santoshprasadnayak@gmail.com \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.