From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tomoya MORINAGA <tomoya.rohm@gmail.com>,
Feng Tang <feng.tang@intel.com>, Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks
Date: Fri, 24 Feb 2012 15:39:42 -0800 [thread overview]
Message-ID: <20120224233942.GA16650@kroah.com> (raw)
In-Reply-To: <4F480E6B.90301@linux.intel.com>
On Fri, Feb 24, 2012 at 02:25:47PM -0800, Darren Hart wrote:
>
>
> On 02/24/2012 01:53 PM, Greg Kroah-Hartman wrote:
> > On Wed, Feb 22, 2012 at 01:46:06AM -0800, Darren Hart wrote:
> >>
> >>
> >> On 02/22/2012 12:52 AM, Alan Cox wrote:
> >>>> + /* Setup UART clock, checking for board specific clocks. */
> >>>> + uartclk = DEFAULT_UARTCLK;
> >>>> +
> >>>> + board_name = dmi_get_system_info(DMI_BOARD_NAME);
> >>>> + if (board_name && strstr(board_name, "CM-iTC"))
> >>>> + uartclk = CMITC_UARTCLK;
> >>>> +
> >>>> + board_name = dmi_get_system_info(DMI_PRODUCT_NAME);
> >>>> + if (board_name && strstr(board_name, "Fish River Island II"))
> >>>> + uartclk = FRI2_UARTCLK;
> >>>> +
> >>>> + port->uartclk = uartclk;
> >>>
> >>> This is confusing, you load product name into a variable called
> >>> board_name ?? perhaps "name" would be clearer ?
> >>
> >> OK, done.
> >
> > "Done" where? Is there a newer patch series I should be looking at
> > here to apply? I'm guessing I can ignore this one, right?
> >
> > consider it ignored :)
>
> I have the V2 patch series here, tested it, was going to send it today
> .... then received a new revision of the hardware/firmware which hides
> the PCI device and the UART is driven by the 8250 driver and requires me
> to use 3318 as the baud ..... ***sigh***. I'm not sure what the right
> thing is to do right now. I'm going to have a conversation with the
> hardware manufacturer and the TWO firmware teams I'm working with.
>
> If anyone has experience with this sort of mess and would like to offer
> a recommended course of action, I'm all ears.
A big stick is usually best to use on the firmware engineers...
Good luck,
greg k-h
next prev parent reply other threads:[~2012-02-24 23:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 1:59 [PATCH 0/4] pch_uart: Cleanups, board quirks, and user uartclk parameter Darren Hart
2012-02-22 1:59 ` [PATCH 1/4] pch_uart: Use uartclk instead of base_baud Darren Hart
2012-02-22 1:59 ` [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks Darren Hart
2012-02-22 8:52 ` Alan Cox
2012-02-22 9:46 ` Darren Hart
2012-02-24 21:53 ` Greg Kroah-Hartman
2012-02-24 22:25 ` Darren Hart
2012-02-24 23:39 ` Greg Kroah-Hartman [this message]
2012-02-22 1:59 ` [PATCH 3/4] pch_uart: Add user_uartclk parameter Darren Hart
2012-02-22 1:59 ` [PATCH 4/4] pch_uart: Use existing default_baud in setup_console Darren Hart
2012-02-22 3:10 ` [PATCH 0/4] pch_uart: Cleanups, board quirks, and user uartclk parameter Tomoya MORINAGA
2012-02-22 3:36 ` Darren Hart
2012-02-22 4:26 ` Tomoya MORINAGA
2012-02-22 6:39 ` Darren Hart
2012-02-22 8:16 ` Tomoya MORINAGA
2012-02-22 8:59 ` Darren Hart
2012-02-22 9:25 ` Feng Tang
2012-02-22 8:58 ` Alan Cox
2012-02-22 9:55 ` Darren Hart
2012-02-22 9:55 ` Darren Hart
-- strict thread matches above, loose matches on Subject: below --
2012-02-29 18:24 [PATCH 1/4] pch_uart: Use uartclk instead of base_baud Darren Hart
2012-02-29 18:24 ` [PATCH 0/4 V2] pch_uart: Cleanups, board quirks, and user uartclk parameter Darren Hart
2012-02-29 18:24 ` [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224233942.GA16650@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dvhart@linux.intel.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.