All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Will Deacon <will.deacon@arm.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations
Date: Sat, 25 Feb 2012 11:37:49 +0900	[thread overview]
Message-ID: <20120225023748.GE21429@verge.net.au> (raw)
In-Reply-To: <1330094447-11900-1-git-send-email-will.deacon@arm.com>

On Fri, Feb 24, 2012 at 02:40:47PM +0000, Will Deacon wrote:
> nommu platforms don't have very interesting swapper_pg_dir pointers and
> usually just #define them to NULL, meaning that we can't include them in
> the vmcoreinfo on the kexec crash path.
> 
> This patch only saves the swapper_pg_dir if we have an MMU.

Hi Will,

might this cover cases where swapper_pg_dir is interesting?

> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>  kernel/kexec.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 7b08867..cb5d13c 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1462,7 +1462,9 @@ static int __init crash_save_vmcoreinfo_init(void)
>  
>  	VMCOREINFO_SYMBOL(init_uts_ns);
>  	VMCOREINFO_SYMBOL(node_online_map);
> +#ifdef CONFIG_MMU
>  	VMCOREINFO_SYMBOL(swapper_pg_dir);
> +#endif
>  	VMCOREINFO_SYMBOL(_stext);
>  	VMCOREINFO_SYMBOL(vmlist);
>  
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-02-25  2:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24 14:40 [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations Will Deacon
2012-02-25  2:37 ` Simon Horman [this message]
2012-02-26 22:58   ` Will Deacon
2012-02-27  0:37     ` Simon Horman
2012-02-27 19:30       ` Will Deacon
2012-02-27 23:52         ` Simon Horman
2012-02-27 23:56           ` Andrew Morton
2012-02-28  0:19             ` Simon Horman
2012-02-28  0:26               ` Andrew Morton
2012-02-28  0:51                 ` Simon Horman
2012-02-28  1:25                   ` Andrew Morton
2012-02-28  1:35                     ` Simon Horman
2012-02-28  9:40                       ` Will Deacon
2012-02-28 20:45                         ` Andrew Morton
2012-02-29  1:32                           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120225023748.GE21429@verge.net.au \
    --to=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.