From: Simon Horman <horms@verge.net.au>
To: Will Deacon <will.deacon@arm.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations
Date: Mon, 27 Feb 2012 09:37:30 +0900 [thread overview]
Message-ID: <20120227003727.GA30831@verge.net.au> (raw)
In-Reply-To: <20120226225842.GA23028@mudshark.cambridge.arm.com>
On Sun, Feb 26, 2012 at 10:58:42PM +0000, Will Deacon wrote:
> On Sat, Feb 25, 2012 at 02:37:49AM +0000, Simon Horman wrote:
> > On Fri, Feb 24, 2012 at 02:40:47PM +0000, Will Deacon wrote:
> > > nommu platforms don't have very interesting swapper_pg_dir pointers and
> > > usually just #define them to NULL, meaning that we can't include them in
> > > the vmcoreinfo on the kexec crash path.
> > >
> > > This patch only saves the swapper_pg_dir if we have an MMU.
> >
> > Hi Will,
>
> Hi Simon,
>
> > might this cover cases where swapper_pg_dir is interesting?
>
> The only case where it's interesting is when you have CONFIG_MMU enabled -
> otherwise it's always NULL. If it's #defined as NULL, the current code will
> fail at build time so simply omitting it from the dump seems like the best
> bet to me (the alternative being to add a NULL entry explicitly, but I don't
> see what the gains us).
Hi Will,
thanks for the clarification. FWIW I am happy with your patch.
Reviewed-by: Simon Horman <horms@verge.net.au>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-02-27 0:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 14:40 [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations Will Deacon
2012-02-25 2:37 ` Simon Horman
2012-02-26 22:58 ` Will Deacon
2012-02-27 0:37 ` Simon Horman [this message]
2012-02-27 19:30 ` Will Deacon
2012-02-27 23:52 ` Simon Horman
2012-02-27 23:56 ` Andrew Morton
2012-02-28 0:19 ` Simon Horman
2012-02-28 0:26 ` Andrew Morton
2012-02-28 0:51 ` Simon Horman
2012-02-28 1:25 ` Andrew Morton
2012-02-28 1:35 ` Simon Horman
2012-02-28 9:40 ` Will Deacon
2012-02-28 20:45 ` Andrew Morton
2012-02-29 1:32 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227003727.GA30831@verge.net.au \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.