From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH WIP] ARM: kirkwood: covert orion-spi to fdt.
Date: Tue, 28 Feb 2012 10:04:14 +0000 [thread overview]
Message-ID: <201202281004.14366.arnd@arndb.de> (raw)
In-Reply-To: <20120228094059.GA27255@lunn.ch>
On Tuesday 28 February 2012, Andrew Lunn wrote:
> I think this code belongs on the board-dts.c file. kirkwood_clk_ctrl
> is a global so can be set from anywhere. It is also set in other files
> than common.c, eg pcie.c.
Ok, that makes sense.
> In the end, i hope this all goes away. I have patches based on Mike's
> generic clk infrastructure, which adds clk/clkdev to all orion based
> machines. So the SPI driver, in its probe function will get its clock,
> enable it, and also find out the speed of it. The release function
> also disables the clock, turning it off if nobody else is using it.
>
> I just hope the generic clk does not take too long to land.
Excellent, that will of course be the best solution in the long run.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH WIP] ARM: kirkwood: covert orion-spi to fdt.
Date: Tue, 28 Feb 2012 10:04:14 +0000 [thread overview]
Message-ID: <201202281004.14366.arnd@arndb.de> (raw)
In-Reply-To: <20120228094059.GA27255-g2DYL2Zd6BY@public.gmane.org>
On Tuesday 28 February 2012, Andrew Lunn wrote:
> I think this code belongs on the board-dts.c file. kirkwood_clk_ctrl
> is a global so can be set from anywhere. It is also set in other files
> than common.c, eg pcie.c.
Ok, that makes sense.
> In the end, i hope this all goes away. I have patches based on Mike's
> generic clk infrastructure, which adds clk/clkdev to all orion based
> machines. So the SPI driver, in its probe function will get its clock,
> enable it, and also find out the speed of it. The release function
> also disables the clock, turning it off if nobody else is using it.
>
> I just hope the generic clk does not take too long to land.
Excellent, that will of course be the best solution in the long run.
Arnd
next prev parent reply other threads:[~2012-02-28 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 9:40 [PATCH WIP] ARM: kirkwood: covert orion-spi to fdt Andrew Lunn
2012-02-28 10:04 ` Arnd Bergmann [this message]
2012-02-28 10:04 ` Arnd Bergmann
2012-02-28 15:06 ` Jason
2012-02-28 15:06 ` Jason
-- strict thread matches above, loose matches on Subject: below --
2012-02-27 22:31 Jason Cooper
2012-02-27 22:31 ` Jason Cooper
2012-02-28 7:39 ` Arnd Bergmann
2012-02-28 7:39 ` Arnd Bergmann
2012-02-28 15:25 ` Jason
2012-02-28 15:25 ` Jason
2012-02-28 16:07 ` Arnd Bergmann
2012-02-28 16:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202281004.14366.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.