All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] OMAP4: dma: Correct CPU version check for dma_common_ch_end
Date: Tue, 28 Feb 2012 14:37:44 -0800	[thread overview]
Message-ID: <20120228223744.GF18901@atomide.com> (raw)
In-Reply-To: <1329983081-9494-1-git-send-email-peter.ujfalusi@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [120222 23:13]:
> CCDN is the last common channel register in all OMAP4 versions. Use
> cpu_is_omap44xx() instead of the cpu_is_omap4430().
> cpu_is_omap4430() returns 0 unconditionally. This causes that the
> dma_common_ch_end register variable is not configured correctly on OMAP4, not
> even for OMAP4430.
> Because of this, registers between CCFN - CCDN will be not cleard in the
> omap2_clear_dma function in OMAP4.

Thanks applying into fixes-non-critical as discussed for the earlier
version of this patch.

Regards,

Tony

      reply	other threads:[~2012-02-28 22:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  7:44 [PATCH v2] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
2012-02-28 22:37 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228223744.GF18901@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.