All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] OMAP4: dma: Correct CPU version check for dma_common_ch_end
@ 2012-02-23  7:44 Peter Ujfalusi
  2012-02-28 22:37 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2012-02-23  7:44 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap

CCDN is the last common channel register in all OMAP4 versions. Use
cpu_is_omap44xx() instead of the cpu_is_omap4430().
cpu_is_omap4430() returns 0 unconditionally. This causes that the
dma_common_ch_end register variable is not configured correctly on OMAP4, not
even for OMAP4430.
Because of this, registers between CCFN - CCDN will be not cleard in the
omap2_clear_dma function in OMAP4.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 arch/arm/mach-omap2/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index a59a45a..b19d849 100644
--- a/arch/arm/mach-omap2/dma.c
+++ b/arch/arm/mach-omap2/dma.c
@@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
 
 	dma_stride		= OMAP2_DMA_STRIDE;
 	dma_common_ch_start	= CSDP;
-	if (cpu_is_omap3630() || cpu_is_omap4430())
+	if (cpu_is_omap3630() || cpu_is_omap44xx())
 		dma_common_ch_end = CCDN;
 	else
 		dma_common_ch_end = CCFN;
-- 
1.7.8.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] OMAP4: dma: Correct CPU version check for dma_common_ch_end
  2012-02-23  7:44 [PATCH v2] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
@ 2012-02-28 22:37 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-02-28 22:37 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: linux-omap

* Peter Ujfalusi <peter.ujfalusi@ti.com> [120222 23:13]:
> CCDN is the last common channel register in all OMAP4 versions. Use
> cpu_is_omap44xx() instead of the cpu_is_omap4430().
> cpu_is_omap4430() returns 0 unconditionally. This causes that the
> dma_common_ch_end register variable is not configured correctly on OMAP4, not
> even for OMAP4430.
> Because of this, registers between CCFN - CCDN will be not cleard in the
> omap2_clear_dma function in OMAP4.

Thanks applying into fixes-non-critical as discussed for the earlier
version of this patch.

Regards,

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-28 22:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23  7:44 [PATCH v2] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
2012-02-28 22:37 ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.