From: Johan Hedberg <johan.hedberg@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Bluetooth: change min_t() cast in hci_reassembly()
Date: Thu, 01 Mar 2012 01:40:33 +0000 [thread overview]
Message-ID: <20120301014033.GC26492@x220> (raw)
In-Reply-To: <20120228065759.GD20506@elgon.mountain>
Hi Dan,
On Tue, Feb 28, 2012, Dan Carpenter wrote:
> "count" is type int so the cast to __u16 truncates the high bits away
> and triggers a Smatch static checker warning. It looks like a high
> value of count could cause a forever loop, but I didn't follow it
> through to see if count is capped somewhere.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index e6cbb8a..db484a8 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1966,7 +1966,7 @@ static int hci_reassembly(struct hci_dev *hdev, int type, void *data,
>
> while (count) {
> scb = (void *) skb->cb;
> - len = min_t(__u16, scb->expect, count);
> + len = min_t(uint, scb->expect, count);
>
> memcpy(skb_put(skb, len), data, len);
Applied to my bluetooth-next tree. Thanks.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Bluetooth: change min_t() cast in hci_reassembly()
Date: Wed, 29 Feb 2012 19:40:33 -0600 [thread overview]
Message-ID: <20120301014033.GC26492@x220> (raw)
In-Reply-To: <20120228065759.GD20506@elgon.mountain>
Hi Dan,
On Tue, Feb 28, 2012, Dan Carpenter wrote:
> "count" is type int so the cast to __u16 truncates the high bits away
> and triggers a Smatch static checker warning. It looks like a high
> value of count could cause a forever loop, but I didn't follow it
> through to see if count is capped somewhere.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index e6cbb8a..db484a8 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1966,7 +1966,7 @@ static int hci_reassembly(struct hci_dev *hdev, int type, void *data,
>
> while (count) {
> scb = (void *) skb->cb;
> - len = min_t(__u16, scb->expect, count);
> + len = min_t(uint, scb->expect, count);
>
> memcpy(skb_put(skb, len), data, len);
Applied to my bluetooth-next tree. Thanks.
Johan
next prev parent reply other threads:[~2012-03-01 1:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 6:57 [patch] Bluetooth: change min_t() cast in hci_reassembly() Dan Carpenter
2012-02-28 6:57 ` Dan Carpenter
2012-02-28 16:20 ` Marcel Holtmann
2012-02-28 16:20 ` Marcel Holtmann
2012-03-01 1:40 ` Johan Hedberg [this message]
2012-03-01 1:40 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301014033.GC26492@x220 \
--to=johan.hedberg@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.