From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: netfilter@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, bart.de.schuymer@pandora.be,
netfilter-devel@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [Bridge] [PATCH 2/3] netfilter: potential null derefence.
Date: Thu, 1 Mar 2012 11:21:36 +0100 [thread overview]
Message-ID: <20120301102136.GB6488@1984> (raw)
In-Reply-To: <1330593434-19275-1-git-send-email-santoshprasadnayak@gmail.com>
On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> I am getting following error.
> " net/bridge/netfilter/ebtables.c:269 ebt_do_table()
> error: potential null derefence 'cs'"
>
> i = cs[sp].n; // If cs == Null then this will cause problem.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bridge/netfilter/ebtables.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index f3fcbd9..9c0f177 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
> smp_processor_id());
> if (private->chainstack)
> cs = private->chainstack[smp_processor_id()];
> - else
> + else {
> cs = NULL;
> + goto out;
There is no "out" label in ebt_do_table !!
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
shemminger@vyatta.com, davem@davemloft.net,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] netfilter: potential null derefence.
Date: Thu, 01 Mar 2012 10:21:36 +0000 [thread overview]
Message-ID: <20120301102136.GB6488@1984> (raw)
In-Reply-To: <1330593434-19275-1-git-send-email-santoshprasadnayak@gmail.com>
On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> I am getting following error.
> " net/bridge/netfilter/ebtables.c:269 ebt_do_table()
> error: potential null derefence 'cs'"
>
> i = cs[sp].n; // If cs = Null then this will cause problem.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bridge/netfilter/ebtables.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index f3fcbd9..9c0f177 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
> smp_processor_id());
> if (private->chainstack)
> cs = private->chainstack[smp_processor_id()];
> - else
> + else {
> cs = NULL;
> + goto out;
There is no "out" label in ebt_do_table !!
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
shemminger@vyatta.com, davem@davemloft.net,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] netfilter: potential null derefence.
Date: Thu, 1 Mar 2012 11:21:36 +0100 [thread overview]
Message-ID: <20120301102136.GB6488@1984> (raw)
In-Reply-To: <1330593434-19275-1-git-send-email-santoshprasadnayak@gmail.com>
On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> I am getting following error.
> " net/bridge/netfilter/ebtables.c:269 ebt_do_table()
> error: potential null derefence 'cs'"
>
> i = cs[sp].n; // If cs == Null then this will cause problem.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bridge/netfilter/ebtables.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index f3fcbd9..9c0f177 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
> smp_processor_id());
> if (private->chainstack)
> cs = private->chainstack[smp_processor_id()];
> - else
> + else {
> cs = NULL;
> + goto out;
There is no "out" label in ebt_do_table !!
next prev parent reply other threads:[~2012-03-01 10:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:17 [Bridge] [PATCH 2/3] netfilter: potential null derefence santosh nayak
2012-03-01 9:29 ` santosh nayak
2012-03-01 9:17 ` santosh nayak
2012-03-01 10:21 ` Pablo Neira Ayuso [this message]
2012-03-01 10:21 ` Pablo Neira Ayuso
2012-03-01 10:21 ` Pablo Neira Ayuso
2012-03-01 10:23 ` [Bridge] " santosh prasad nayak
2012-03-01 10:35 ` santosh prasad nayak
2012-03-01 10:23 ` santosh prasad nayak
2012-03-01 12:30 ` [Bridge] " Pablo Neira Ayuso
2012-03-01 12:30 ` Pablo Neira Ayuso
2012-03-01 12:30 ` Pablo Neira Ayuso
2012-03-02 21:31 ` [Bridge] " Bart De Schuymer
2012-03-02 21:31 ` Bart De Schuymer
2012-03-02 21:31 ` Bart De Schuymer
2012-03-02 21:31 ` [Bridge] " Bart De Schuymer
2012-03-03 9:04 ` santosh prasad nayak
2012-03-03 9:16 ` santosh prasad nayak
2012-03-03 9:11 ` Pablo Neira Ayuso
2012-03-03 9:11 ` Pablo Neira Ayuso
2012-03-03 9:11 ` Pablo Neira Ayuso
2012-03-03 9:11 ` [Bridge] " Pablo Neira Ayuso
2012-03-02 1:22 ` Pablo Neira Ayuso
2012-03-02 1:22 ` Pablo Neira Ayuso
2012-03-02 1:22 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301102136.GB6488@1984 \
--to=pablo@netfilter.org \
--cc=bart.de.schuymer@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.