From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: netfilter@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, bart.de.schuymer@pandora.be,
netfilter-devel@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [Bridge] [PATCH 3/3] netfilter: Remove redundant code.
Date: Thu, 1 Mar 2012 11:23:41 +0100 [thread overview]
Message-ID: <20120301102341.GC6488@1984> (raw)
In-Reply-To: <1330593466-19317-1-git-send-email-santoshprasadnayak@gmail.com>
On Thu, Mar 01, 2012 at 02:47:46PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Remove the redundant code.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bridge/netfilter/ebtables.c | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 9c0f177..1efc234 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -226,10 +226,8 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
>
> if (EBT_MATCH_ITERATE(point, ebt_do_match, skb, &acpar) != 0)
> goto letscontinue;
> - if (acpar.hotdrop) {
> - read_unlock_bh(&table->lock);
> - return NF_DROP;
> - }
> + if (acpar.hotdrop)
> + goto out;
This is really broken! there's no "out" label in ebt_do_table as in
the previous patch!
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
shemminger@vyatta.com, davem@davemloft.net,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: Remove redundant code.
Date: Thu, 01 Mar 2012 10:23:41 +0000 [thread overview]
Message-ID: <20120301102341.GC6488@1984> (raw)
In-Reply-To: <1330593466-19317-1-git-send-email-santoshprasadnayak@gmail.com>
On Thu, Mar 01, 2012 at 02:47:46PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Remove the redundant code.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bridge/netfilter/ebtables.c | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 9c0f177..1efc234 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -226,10 +226,8 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
>
> if (EBT_MATCH_ITERATE(point, ebt_do_match, skb, &acpar) != 0)
> goto letscontinue;
> - if (acpar.hotdrop) {
> - read_unlock_bh(&table->lock);
> - return NF_DROP;
> - }
> + if (acpar.hotdrop)
> + goto out;
This is really broken! there's no "out" label in ebt_do_table as in
the previous patch!
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
shemminger@vyatta.com, davem@davemloft.net,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: Remove redundant code.
Date: Thu, 1 Mar 2012 11:23:41 +0100 [thread overview]
Message-ID: <20120301102341.GC6488@1984> (raw)
In-Reply-To: <1330593466-19317-1-git-send-email-santoshprasadnayak@gmail.com>
On Thu, Mar 01, 2012 at 02:47:46PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Remove the redundant code.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> net/bridge/netfilter/ebtables.c | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 9c0f177..1efc234 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -226,10 +226,8 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
>
> if (EBT_MATCH_ITERATE(point, ebt_do_match, skb, &acpar) != 0)
> goto letscontinue;
> - if (acpar.hotdrop) {
> - read_unlock_bh(&table->lock);
> - return NF_DROP;
> - }
> + if (acpar.hotdrop)
> + goto out;
This is really broken! there's no "out" label in ebt_do_table as in
the previous patch!
next prev parent reply other threads:[~2012-03-01 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:17 [Bridge] [PATCH 3/3] netfilter: Remove redundant code santosh nayak
2012-03-01 9:29 ` santosh nayak
2012-03-01 9:17 ` santosh nayak
2012-03-01 10:23 ` Pablo Neira Ayuso [this message]
2012-03-01 10:23 ` Pablo Neira Ayuso
2012-03-01 10:23 ` Pablo Neira Ayuso
2012-03-01 10:24 ` [Bridge] " santosh prasad nayak
2012-03-01 10:36 ` santosh prasad nayak
2012-03-01 10:24 ` santosh prasad nayak
2012-03-01 10:24 ` santosh prasad nayak
2012-03-01 12:30 ` [Bridge] " Pablo Neira Ayuso
2012-03-01 12:30 ` Pablo Neira Ayuso
2012-03-01 12:30 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301102341.GC6488@1984 \
--to=pablo@netfilter.org \
--cc=bart.de.schuymer@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.