From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Zhao Chenhui
<chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Li Yang <leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep
Date: Thu, 1 Mar 2012 11:27:24 +0000 [thread overview]
Message-ID: <20120301112724.GE8441@trinity.fluff.org> (raw)
In-Reply-To: <20120229183436.GA30545-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
> Hi,
>
> On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
> > When entering deep sleep, the value in the registers I2CFDR and
> > I2CDFSRR are lost. This causes I2C access to fail after resuming.
> >
> > Add suspend/resume routines to save/restore the registers
> > I2CFDR and I2CDFSRR.
> >
> > Signed-off-by: Zhao Chenhui <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Li Yang <leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> > drivers/i2c/busses/i2c-mpc.c | 34 +++++++++++++++++++++++++++++++++-
> > 1 files changed, 33 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> > index a8ebb84..f95a647 100644
> > --- a/drivers/i2c/busses/i2c-mpc.c
> > +++ b/drivers/i2c/busses/i2c-mpc.c
> > @@ -1,7 +1,9 @@
> > /*
> > * (C) Copyright 2003-2004
> > * Humboldt Solutions Ltd, adrian-nKrwMtk+6WksDtB2XHyCLA@public.gmane.org
> > -
> > + *
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + *
>
> I'd think the change is too trivial to claim copyright on the file.
I agree with that.
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben-i2c@fluff.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Zhao Chenhui <chenhui.zhao@freescale.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Yang <leoli@freescale.com>
Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep
Date: Thu, 1 Mar 2012 11:27:24 +0000 [thread overview]
Message-ID: <20120301112724.GE8441@trinity.fluff.org> (raw)
In-Reply-To: <20120229183436.GA30545@pengutronix.de>
On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
> Hi,
>
> On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
> > When entering deep sleep, the value in the registers I2CFDR and
> > I2CDFSRR are lost. This causes I2C access to fail after resuming.
> >
> > Add suspend/resume routines to save/restore the registers
> > I2CFDR and I2CDFSRR.
> >
> > Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> > Signed-off-by: Li Yang <leoli@freescale.com>
> > ---
> > drivers/i2c/busses/i2c-mpc.c | 34 +++++++++++++++++++++++++++++++++-
> > 1 files changed, 33 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> > index a8ebb84..f95a647 100644
> > --- a/drivers/i2c/busses/i2c-mpc.c
> > +++ b/drivers/i2c/busses/i2c-mpc.c
> > @@ -1,7 +1,9 @@
> > /*
> > * (C) Copyright 2003-2004
> > * Humboldt Solutions Ltd, adrian@humboldt.co.uk.
> > -
> > + *
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + *
>
> I'd think the change is too trivial to claim copyright on the file.
I agree with that.
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2012-03-01 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 10:39 [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep Zhao Chenhui
2012-02-29 10:39 ` Zhao Chenhui
[not found] ` <1330511961-22498-1-git-send-email-chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-02-29 13:02 ` Shubhrajyoti Datta
2012-02-29 13:02 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2ctLm8FKgTek6u9H0jzWJv1bbBUnvDHZfEA=p2ReK8ybUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-29 18:08 ` Tabi Timur-B04825
2012-02-29 18:08 ` Tabi Timur-B04825
2012-02-29 18:45 ` Wolfram Sang
2012-02-29 18:45 ` Wolfram Sang
[not found] ` <20120229183436.GA30545-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-01 11:27 ` Ben Dooks [this message]
2012-03-01 11:27 ` Ben Dooks
2012-04-17 14:21 ` Wolfram Sang
2012-04-17 14:21 ` Wolfram Sang
[not found] ` <20120417142105.GA21802-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-18 10:20 ` Li Yang-R58472
2012-04-18 10:20 ` Li Yang-R58472
[not found] ` <94F013E7935FF44C83EBE7784D62AD3F092D1DC7-RL0Hj/+nBVC81RJBUSuqCa4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-04-18 10:33 ` Wolfram Sang
2012-04-18 10:33 ` Wolfram Sang
[not found] ` <20120418103334.GD2232-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-18 14:44 ` Li Yang
2012-04-18 14:44 ` Li Yang
[not found] ` <CADRPPNQRLyZK-zjeLUYCZtLe+8HhFzFALCMyPeaCGX+buaf+ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-18 21:49 ` Tabi Timur-B04825
2012-04-18 21:49 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301112724.GE8441@trinity.fluff.org \
--to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.