All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Daniel Mack <zonque@gmail.com>, Rajendra Nayak <rnayak@ti.com>
Cc: "T Krishnamoorthy, Balaji" <balajitk@ti.com>,
	linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: hsmmc: add max_freq field
Date: Thu, 1 Mar 2012 16:11:21 -0800	[thread overview]
Message-ID: <20120302001121.GE18901@atomide.com> (raw)
In-Reply-To: <CACTFLAMCoKfQbTe2RLTvi1_CH0nKzAOthAwrifNe2+F2sf3uPA@mail.gmail.com>

Hi,

* Daniel Mack <zonque@gmail.com> [120217 05:13]:
> ping? Could anyone care for queueing this please?
 
I suggest Rajendra queue up omap_hsmmc.c patches as he's already
patching it.

Regards,

Tony

 
> On Thu, Dec 29, 2011 at 2:22 PM, Daniel Mack <zonque@gmail.com> wrote:
> > On 12/23/2011 04:40 PM, T Krishnamoorthy, Balaji wrote:
> >> On Wed, Dec 14, 2011 at 6:52 PM, Daniel Mack <zonque@gmail.com> wrote:
> >>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> >>> index 101cd31..8215ef9 100644
> >>> --- a/drivers/mmc/host/omap_hsmmc.c
> >>> +++ b/drivers/mmc/host/omap_hsmmc.c
> >>> @@ -1927,8 +1927,12 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
> >>>        if (mmc_slot(host).vcc_aux_disable_is_sleep)
> >>>                mmc_slot(host).no_off = 1;
> >>>
> >>> -       mmc->f_min      = OMAP_MMC_MIN_CLOCK;
> >>> -       mmc->f_max      = OMAP_MMC_MAX_CLOCK;
> >>> +       mmc->f_min = OMAP_MMC_MIN_CLOCK;
> >>
> >> Stray change for f_min ?
> >
> > No, this was intended. The indentation doesn't make sense anymore when
> > not grouped with the f_max assignment.
> >
> > Other than that, what is necessary to get this picked? Tony? :)
> >
> >
> > Thanks,
> > Daniel

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: hsmmc: add max_freq field
Date: Thu, 1 Mar 2012 16:11:21 -0800	[thread overview]
Message-ID: <20120302001121.GE18901@atomide.com> (raw)
In-Reply-To: <CACTFLAMCoKfQbTe2RLTvi1_CH0nKzAOthAwrifNe2+F2sf3uPA@mail.gmail.com>

Hi,

* Daniel Mack <zonque@gmail.com> [120217 05:13]:
> ping? Could anyone care for queueing this please?
 
I suggest Rajendra queue up omap_hsmmc.c patches as he's already
patching it.

Regards,

Tony

 
> On Thu, Dec 29, 2011 at 2:22 PM, Daniel Mack <zonque@gmail.com> wrote:
> > On 12/23/2011 04:40 PM, T Krishnamoorthy, Balaji wrote:
> >> On Wed, Dec 14, 2011 at 6:52 PM, Daniel Mack <zonque@gmail.com> wrote:
> >>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> >>> index 101cd31..8215ef9 100644
> >>> --- a/drivers/mmc/host/omap_hsmmc.c
> >>> +++ b/drivers/mmc/host/omap_hsmmc.c
> >>> @@ -1927,8 +1927,12 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
> >>> ? ? ? ?if (mmc_slot(host).vcc_aux_disable_is_sleep)
> >>> ? ? ? ? ? ? ? ?mmc_slot(host).no_off = 1;
> >>>
> >>> - ? ? ? mmc->f_min ? ? ?= OMAP_MMC_MIN_CLOCK;
> >>> - ? ? ? mmc->f_max ? ? ?= OMAP_MMC_MAX_CLOCK;
> >>> + ? ? ? mmc->f_min = OMAP_MMC_MIN_CLOCK;
> >>
> >> Stray change for f_min ?
> >
> > No, this was intended. The indentation doesn't make sense anymore when
> > not grouped with the f_max assignment.
> >
> > Other than that, what is necessary to get this picked? Tony? :)
> >
> >
> > Thanks,
> > Daniel

  parent reply	other threads:[~2012-03-02  0:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 13:22 [PATCH] ARM: OMAP: hsmmc: add max_freq field Daniel Mack
2011-12-14 13:22 ` Daniel Mack
2011-12-22 18:51 ` Tony Lindgren
2011-12-22 18:51   ` Tony Lindgren
2011-12-22 19:37 ` Kishore Kadiyala
2011-12-22 19:37   ` Kishore Kadiyala
2011-12-22 23:02   ` Daniel Mack
2011-12-22 23:02     ` Daniel Mack
2011-12-23 15:40 ` T Krishnamoorthy, Balaji
2011-12-23 15:40   ` T Krishnamoorthy, Balaji
2011-12-29 13:22   ` Daniel Mack
2011-12-29 13:22     ` Daniel Mack
2012-02-17 13:44     ` Daniel Mack
2012-02-17 13:44       ` Daniel Mack
2012-02-17 17:09       ` Cousson, Benoit
2012-02-17 17:09         ` Cousson, Benoit
2012-03-02  0:11       ` Tony Lindgren [this message]
2012-03-02  0:11         ` Tony Lindgren
2012-03-02  7:11         ` S, Venkatraman
2012-03-02  7:11           ` S, Venkatraman
2012-03-02  9:14           ` S, Venkatraman
2012-03-02  9:14             ` S, Venkatraman
  -- strict thread matches above, loose matches on Subject: below --
2012-02-19 12:20 Daniel Mack
2012-02-19 12:20 ` Daniel Mack
2012-02-19 16:16 ` Chris Ball
2012-02-19 16:16   ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120302001121.GE18901@atomide.com \
    --to=tony@atomide.com \
    --cc=balajitk@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.