All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Wollesen <ericw@xmtp.net>
Cc: Doug Thompson <dougthompson@xmission.com>,
	list-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch] edac i5000: fix pointer math in i5000_get_mc_regs()
Date: Fri, 02 Mar 2012 06:54:41 +0000	[thread overview]
Message-ID: <20120302065441.GB24508@elgon.mountain> (raw)

"pvt->ambase" is a u64 datatype.  The intent here is to fill the first
half in the first call to pci_read_config_dword() and the other half in
the second.  Unfortunately the pointer math is wrong so we set the wrong
data.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I don't have the hardware to test this.  Please review carefully.

diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
index 4dc3ac2..fcdc4ab 100644
--- a/drivers/edac/i5000_edac.c
+++ b/drivers/edac/i5000_edac.c
@@ -1130,7 +1130,7 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
 	pci_read_config_dword(pvt->system_address, AMBASE,
 			(u32 *) & pvt->ambase);
 	pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
-			((u32 *) & pvt->ambase) + sizeof(u32));
+			(u32 *)((char *) &pvt->ambase + sizeof(u32)));
 
 	maxdimmperch = pvt->maxdimmperch;
 	maxch = pvt->maxch;

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Wollesen <ericw@xmtp.net>
Cc: Doug Thompson <dougthompson@xmission.com>,
	list-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch] edac i5000: fix pointer math in i5000_get_mc_regs()
Date: Fri, 2 Mar 2012 09:54:41 +0300	[thread overview]
Message-ID: <20120302065441.GB24508@elgon.mountain> (raw)

"pvt->ambase" is a u64 datatype.  The intent here is to fill the first
half in the first call to pci_read_config_dword() and the other half in
the second.  Unfortunately the pointer math is wrong so we set the wrong
data.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I don't have the hardware to test this.  Please review carefully.

diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
index 4dc3ac2..fcdc4ab 100644
--- a/drivers/edac/i5000_edac.c
+++ b/drivers/edac/i5000_edac.c
@@ -1130,7 +1130,7 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
 	pci_read_config_dword(pvt->system_address, AMBASE,
 			(u32 *) & pvt->ambase);
 	pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
-			((u32 *) & pvt->ambase) + sizeof(u32));
+			(u32 *)((char *) &pvt->ambase + sizeof(u32)));
 
 	maxdimmperch = pvt->maxdimmperch;
 	maxch = pvt->maxch;

             reply	other threads:[~2012-03-02  6:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02  6:54 Dan Carpenter [this message]
2012-03-02  6:54 ` [patch] edac i5000: fix pointer math in i5000_get_mc_regs() Dan Carpenter
2012-03-02  9:00 ` walter harms
2012-03-02  9:00   ` walter harms
2012-03-02 19:09   ` Dan Carpenter
2012-03-02 19:09     ` Dan Carpenter
2012-03-02 19:20     ` walter harms
2012-03-02 19:20       ` walter harms
2012-03-05  8:59   ` [patch v2] edac i5000, i5400: " Dan Carpenter
2012-03-05  9:01     ` Dan Carpenter
2012-03-05  9:45     ` walter harms
2012-03-05  9:45       ` walter harms
2012-03-05  9:52       ` Dan Carpenter
2012-03-05  9:52         ` Dan Carpenter
2012-03-05 10:07         ` walter harms
2012-03-05 10:07           ` walter harms
2012-03-06  6:38         ` [patch v3] " Dan Carpenter
2012-03-06  6:38           ` Dan Carpenter
2012-03-06  8:50           ` walter harms
2012-03-06  8:50             ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120302065441.GB24508@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=dougthompson@xmission.com \
    --cc=ericw@xmtp.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=list-edac@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.