From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] repair: fix the variable-width nlink array
Date: Fri, 2 Mar 2012 02:44:33 -0500 [thread overview]
Message-ID: <20120302074433.GA4117@infradead.org> (raw)
In-Reply-To: <20120301212822.GM7762@sgi.com>
On Thu, Mar 01, 2012 at 03:28:22PM -0600, Ben Myers wrote:
> Hey Christoph,
>
> On Tue, Feb 28, 2012 at 12:42:24PM -0500, Christoph Hellwig wrote:
> > It looks like we currently never grow the variable-width nlink array
> > if only the on-disk nlink size overflows 8 bits. This leads to a major
> > mess in nlink counting, and eventually an assert in phase7.
> >
> > Replace the indirect all mess with a union that allows doing proper
> > array arithmetics while we're at it.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> This looks good to me. I enjoyed the fallthrus in set_inode_disk_nlinks
> and add_inode_ref.
>
> I haven't tested with this many links though... Are there any xfstests
> that would exercise this?
There is none yet. I've tested it with Arekm's test metadump, which
I've added to my nasty images collection. I'll create a testcase
reproducing this artifically.
> On my machine test 030 has regressed. It passed on 3.1.7.
That's an older change. I have a fix in my local tree, but it needs
polishing so that it still works with older repair versions.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-02 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 17:42 [PATCH 1/2] repair: fix the variable-width nlink array Christoph Hellwig
2012-02-28 17:42 ` [PATCH 2/2] repair: fix messages from set_nlinks Christoph Hellwig
2012-03-02 22:09 ` Eric Sandeen
2012-03-01 21:28 ` [PATCH 1/2] repair: fix the variable-width nlink array Ben Myers
2012-03-02 7:44 ` Christoph Hellwig [this message]
2012-03-26 17:49 ` Ben Myers
2012-03-27 14:59 ` Christoph Hellwig
2012-03-02 9:41 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302074433.GA4117@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.